Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2681393008: Accommodate Swarming try number into log stream. (Closed)

Created:
3 years, 10 months ago by dnj
Modified:
3 years, 10 months ago
Reviewers:
hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Accommodate Swarming try number into log stream. Incorporate the Swarming try number into the LogDog log stream calculation, which uses the *run ID*, not the task ID, to generate its stream path. BUG=chromium:687625 TEST=unit Review-Url: https://codereview.chromium.org/2681393008 Committed: https://github.com/luci/luci-go/commit/e5aca54945978b7f4397c02b71609574004850dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -15 lines) Patch
M milo/appengine/swarming/buildinfo.go View 6 chunks +51 lines, -3 lines 0 comments Download
M milo/appengine/swarming/buildinfo_test.go View 9 chunks +53 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dnj
PTAL. This is likely short-lived, but it will work with all Swarming servers now and ...
3 years, 10 months ago (2017-02-10 21:02:10 UTC) #2
hinoka
lgtm
3 years, 10 months ago (2017-02-10 21:10:37 UTC) #3
hinoka
lgtm
3 years, 10 months ago (2017-02-10 21:10:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681393008/1
3 years, 10 months ago (2017-02-10 21:10:47 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 21:22:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/e5aca54945978b7f4397c02b71609574004850dc

Powered by Google App Engine
This is Rietveld 408576698