Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2681393002: [sync] SYNC_AUTH_ERROR in logs when running sync_integration_tests (Closed)

Created:
3 years, 10 months ago by Patrick Noland
Modified:
3 years, 10 months ago
Reviewers:
pavely
CC:
chromium-reviews, cbentzel+watch_chromium.org, sync-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sync] SYNC_AUTH_ERROR in logs when running sync_integration_tests Switch to a DVLOG(1) and add a bit more detail to the message. BUG=687671 R=pavely@chromium.org Review-Url: https://codereview.chromium.org/2681393002 Cr-Commit-Position: refs/heads/master@{#449422} Committed: https://chromium.googlesource.com/chromium/src/+/27be9c0b8336fbddbcf95bebe2c840ba503af12b

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed "invalid" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/sync/engine_impl/net/server_connection_manager.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Patrick Noland
Pavel, PTAL and let me know if the newly added words are correct/useful
3 years, 10 months ago (2017-02-09 18:58:30 UTC) #3
pavely
lgtm https://codereview.chromium.org/2681393002/diff/1/components/sync/engine_impl/net/server_connection_manager.cc File components/sync/engine_impl/net/server_connection_manager.cc (right): https://codereview.chromium.org/2681393002/diff/1/components/sync/engine_impl/net/server_connection_manager.cc#newcode270 components/sync/engine_impl/net/server_connection_manager.cc:270: "missing or invalid auth token"; "Invalid" doesn't apply ...
3 years, 10 months ago (2017-02-09 20:15:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681393002/20001
3 years, 10 months ago (2017-02-09 20:45:59 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 21:42:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/27be9c0b8336fbddbcf95bebe2c8...

Powered by Google App Engine
This is Rietveld 408576698