Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2681333002: Fixed an issue with fallback on locked profile upon profile deletion. (Closed)

Created:
3 years, 10 months ago by palar
Modified:
3 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed an issue with fallback on locked profile upon profile deletion. BUG=687894 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2681333002 Cr-Commit-Position: refs/heads/master@{#449594} Committed: https://chromium.googlesource.com/chromium/src/+/33e953c922b7dcfa88418ae62d098d6d3e869535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/webui/profile_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
palar
3 years, 10 months ago (2017-02-09 15:12:05 UTC) #1
Bernhard Bauer
LGTM It would be amazing if we could have some tests for the whole profile ...
3 years, 10 months ago (2017-02-09 16:45:33 UTC) #2
palar
On 2017/02/09 16:45:33, Bernhard Bauer wrote: > LGTM > > It would be amazing if ...
3 years, 10 months ago (2017-02-10 10:57:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681333002/1
3 years, 10 months ago (2017-02-10 10:57:26 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 12:09:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/33e953c922b7dcfa88418ae62d09...

Powered by Google App Engine
This is Rietveld 408576698