Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2681323002: [regexp] Update lastIndex semantics in RegExpBuiltinExec (Closed)

Created:
3 years, 10 months ago by jgruber
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Dan Ehrenberg
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Update lastIndex semantics in RegExpBuiltinExec Updated according to the recent spec change at https://github.com/tc39/ecma262/pull/798. BUG=v8:5949 Review-Url: https://codereview.chromium.org/2681323002 Cr-Commit-Position: refs/heads/master@{#43062} Committed: https://chromium.googlesource.com/v8/v8/+/b798b5212a0d16a910e2224bb3aa7b4b23f983f2

Patch Set 1 #

Patch Set 2 : Update test262.status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M src/builtins/builtins-regexp.cc View 2 chunks +21 lines, -21 lines 0 comments Download
M test/mjsunit/regexp.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-2438.js View 1 chunk +2 lines, -6 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
jgruber
3 years, 10 months ago (2017-02-09 12:42:04 UTC) #4
Yang
On 2017/02/09 12:42:04, jgruber wrote: lgtm.
3 years, 10 months ago (2017-02-09 14:43:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681323002/20001
3 years, 10 months ago (2017-02-09 14:52:32 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 14:54:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b798b5212a0d16a910e2224bb3aa7b4b23f...

Powered by Google App Engine
This is Rietveld 408576698