Index: docs/testing/web_platform_tests.md |
diff --git a/docs/testing/web_platform_tests.md b/docs/testing/web_platform_tests.md |
index 6243dee0489f1dff04e933be1815fcd7dd6cdff4..8edfa858c230050fa72e11c729370df0c112f06a 100644 |
--- a/docs/testing/web_platform_tests.md |
+++ b/docs/testing/web_platform_tests.md |
@@ -58,10 +58,14 @@ That script will pull the latest version of the tests from our mirrors of the |
upstream repositories. If any new versions of tests are found, they will be |
committed locally to your local repository. You may then upload the changes. |
+### Enabling import for a new directory |
+ |
If you wish to add more tests (by un-skipping some of the directories currently |
skipped in `W3CImportExpectations`), you can modify that file locally and commit |
-it, and on the next auto-import, the new tests should be imported. If you want |
-to import immediately, you can also run `wpt-import --allow-local-commits`. |
+it, and on the next auto-import, the new tests should be imported. |
+ |
+If you want to import immediately (in order to try the tests out locally, etc) |
+you can also run `wpt-import --allow-local-commits`, but this is not required. |
## Contributing tests back to the Web Platform Tests project. |
@@ -79,6 +83,26 @@ Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest --work \ |
--tests-root=LayoutTests/external/wpt |
``` |
+### What kinds of changes can be upstreamed? |
+ |
+In general, changes involving adding, removing or modifying tests can all be |
+upstreamed. From a Chromium commit, any changes outside of |
+[external/wpt](../../third_party/WebKit/LayoutTests/external/wpt) will not be |
+upstreamed, and any changes `*-expected.txt`, `OWNERS`, and `MANIFEST.json`, |
+will also not be upstreamed. |
+ |
+An entirely new top-level directory could be added in a Chromium commit, |
+although in general you won't need to do this. If this is done, then an entry |
+should be added to `W3CImportExpectations`. |
foolip
2017/02/10 23:43:33
I think we should recommend doing this upstream si
qyearsley
2017/02/10 23:56:24
Makes sense, now changed this recommendation.
|
+ |
+### Web Platform Tests contributing guidelines |
+ |
+The Web Platform Tests has [guidelines for |
+contributors](https://github.com/w3c/web-platform-tests/blob/master/CONTRIBUTING.md). |
foolip
2017/02/10 23:43:33
This documentation is just legal stuff, I think li
qyearsley
2017/02/10 23:56:24
For this CL, I'll just remove this section; we cou
|
+Remember that in general, tests correspond to specs, and tests in Web Platform |
Rick Byers
2017/02/10 18:15:52
I guess I'd suggest keeping everything above, and
qyearsley
2017/02/10 23:56:24
Removing these 3 lines
|
+Tests are intended to be cross-browser testing for conformance to |
+specifications. |
+ |
### Will the exported commits be linked to my GitHub profile? |
The email you commit with in Chromium will be the author of the commit on |