OLD | NEW |
---|---|
1 # Web Platform Tests | 1 # Web Platform Tests |
2 | 2 |
3 The Web Platform Tests project provides a large number of conformance tests for | 3 The Web Platform Tests project provides a large number of conformance tests for |
4 different aspects of the Web Platform. Currently the tests are hosted on GitHub. | 4 different aspects of the Web Platform. Currently the tests are hosted on GitHub. |
5 There are two main repositories, one for the CSS Working Group (aka csswg-test), | 5 There are two main repositories, one for the CSS Working Group (aka csswg-test), |
6 and one for pretty much everything else (aka web-platform-tests). | 6 and one for pretty much everything else (aka web-platform-tests). |
7 | 7 |
8 There is a plan to merge csswg-test into web-platform-tests, so later, there | 8 There is a plan to merge csswg-test into web-platform-tests, so later, there |
9 will be only one repository. | 9 will be only one repository. |
10 | 10 |
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
51 ### Manual import | 51 ### Manual import |
52 | 52 |
53 To pull the latest versions of the tests that are currently being imported, you | 53 To pull the latest versions of the tests that are currently being imported, you |
54 can also directly invoke the | 54 can also directly invoke the |
55 [wpt-import](../../third_party/WebKit/Tools/Scripts/wpt-import) script. | 55 [wpt-import](../../third_party/WebKit/Tools/Scripts/wpt-import) script. |
56 | 56 |
57 That script will pull the latest version of the tests from our mirrors of the | 57 That script will pull the latest version of the tests from our mirrors of the |
58 upstream repositories. If any new versions of tests are found, they will be | 58 upstream repositories. If any new versions of tests are found, they will be |
59 committed locally to your local repository. You may then upload the changes. | 59 committed locally to your local repository. You may then upload the changes. |
60 | 60 |
61 ### Enabling import for a new directory | |
62 | |
61 If you wish to add more tests (by un-skipping some of the directories currently | 63 If you wish to add more tests (by un-skipping some of the directories currently |
62 skipped in `W3CImportExpectations`), you can modify that file locally and commit | 64 skipped in `W3CImportExpectations`), you can modify that file locally and commit |
63 it, and on the next auto-import, the new tests should be imported. If you want | 65 it, and on the next auto-import, the new tests should be imported. |
64 to import immediately, you can also run `wpt-import --allow-local-commits`. | 66 |
67 If you want to import immediately (in order to try the tests out locally, etc) | |
68 you can also run `wpt-import --allow-local-commits`, but this is not required. | |
65 | 69 |
66 ## Contributing tests back to the Web Platform Tests project. | 70 ## Contributing tests back to the Web Platform Tests project. |
67 | 71 |
68 If you need to make changes to Web Platform Tests, just commit your changes | 72 If you need to make changes to Web Platform Tests, just commit your changes |
69 directly to | 73 directly to |
70 [LayoutTests/external/wpt](../../third_party/WebKit/LayoutTests/external/wpt) | 74 [LayoutTests/external/wpt](../../third_party/WebKit/LayoutTests/external/wpt) |
71 and the changes will be automatically upstreamed within 24 hours. | 75 and the changes will be automatically upstreamed within 24 hours. |
72 | 76 |
73 Note: if you're adding a new test in `external/wpt`, you'll need to re-generate | 77 Note: if you're adding a new test in `external/wpt`, you'll need to re-generate |
74 MANIFEST.json manually until [CL 2644783003](https://crrev.com/2644783003) is | 78 MANIFEST.json manually until [CL 2644783003](https://crrev.com/2644783003) is |
75 landed. The command to do so is: | 79 landed. The command to do so is: |
76 | 80 |
77 ```bash | 81 ```bash |
78 Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest --work \ | 82 Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest --work \ |
79 --tests-root=LayoutTests/external/wpt | 83 --tests-root=LayoutTests/external/wpt |
80 ``` | 84 ``` |
81 | 85 |
86 ### What kinds of changes can be upstreamed? | |
87 | |
88 In general, changes involving adding, removing or modifying tests can all be | |
89 upstreamed. From a Chromium commit, any changes outside of | |
90 [external/wpt](../../third_party/WebKit/LayoutTests/external/wpt) will not be | |
91 upstreamed, and any changes `*-expected.txt`, `OWNERS`, and `MANIFEST.json`, | |
92 will also not be upstreamed. | |
93 | |
94 An entirely new top-level directory could be added in a Chromium commit, | |
95 although in general you won't need to do this. If this is done, then an entry | |
96 should be added to `W3CImportExpectations`. | |
foolip
2017/02/10 23:43:33
I think we should recommend doing this upstream si
qyearsley
2017/02/10 23:56:24
Makes sense, now changed this recommendation.
| |
97 | |
98 ### Web Platform Tests contributing guidelines | |
99 | |
100 The Web Platform Tests has [guidelines for | |
101 contributors](https://github.com/w3c/web-platform-tests/blob/master/CONTRIBUTING .md). | |
foolip
2017/02/10 23:43:33
This documentation is just legal stuff, I think li
qyearsley
2017/02/10 23:56:24
For this CL, I'll just remove this section; we cou
| |
102 Remember that in general, tests correspond to specs, and tests in Web Platform | |
Rick Byers
2017/02/10 18:15:52
I guess I'd suggest keeping everything above, and
qyearsley
2017/02/10 23:56:24
Removing these 3 lines
| |
103 Tests are intended to be cross-browser testing for conformance to | |
104 specifications. | |
105 | |
82 ### Will the exported commits be linked to my GitHub profile? | 106 ### Will the exported commits be linked to my GitHub profile? |
83 | 107 |
84 The email you commit with in Chromium will be the author of the commit on | 108 The email you commit with in Chromium will be the author of the commit on |
85 GitHub. You can [add it as a secondary address on your GitHub | 109 GitHub. You can [add it as a secondary address on your GitHub |
86 account](https://help.github.com/articles/adding-an-email-address-to-your-github -account/) | 110 account](https://help.github.com/articles/adding-an-email-address-to-your-github -account/) |
87 to link your exported commits to your GitHub profile. | 111 to link your exported commits to your GitHub profile. |
88 | 112 |
89 ### What if there are conflicts? | 113 ### What if there are conflicts? |
90 | 114 |
91 This cannot be avoided entirely as the two repositories are independent, but | 115 This cannot be avoided entirely as the two repositories are independent, but |
92 should be rare with frequent imports and exports. When it does happen, manual | 116 should be rare with frequent imports and exports. When it does happen, manual |
93 intervention will be needed and in non-trivial cases you may be asked to help | 117 intervention will be needed and in non-trivial cases you may be asked to help |
94 resolve the conflict. | 118 resolve the conflict. |
95 | 119 |
96 ### Direct pull requests | 120 ### Direct pull requests |
97 | 121 |
98 It's still possible to make direct pull requests to web-platform-tests. The | 122 It's still possible to make direct pull requests to web-platform-tests. The |
99 processes for getting new tests committed the W3C repos are at | 123 processes for getting new tests committed the W3C repos are at |
100 http://testthewebforward.org/docs/. Some specifics are at | 124 http://testthewebforward.org/docs/. Some specifics are at |
101 http://testthewebforward.org/docs/github-101.html. | 125 http://testthewebforward.org/docs/github-101.html. |
OLD | NEW |