Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: pkg/analysis_server/lib/src/computer/computer_hover.dart

Issue 2681233005: Analysis.getHover should return the field's documentation for field formal parameters. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/computer/computer_hover.dart
diff --git a/pkg/analysis_server/lib/src/computer/computer_hover.dart b/pkg/analysis_server/lib/src/computer/computer_hover.dart
index 1e3b80729f583d0d8d4dc0de78b61ece63db60c7..5648d886fc9379776e43c7d72a088c14fc077a9e 100644
--- a/pkg/analysis_server/lib/src/computer/computer_hover.dart
+++ b/pkg/analysis_server/lib/src/computer/computer_hover.dart
@@ -82,7 +82,9 @@ class DartUnitHoverComputer {
AstNode parent = expression.parent;
DartType staticType = null;
DartType propagatedType = expression.propagatedType;
- if (element == null || element is VariableElement) {
+ if (element is ParameterElement) {
+ staticType = element.type;
+ } else if (element == null || element is VariableElement) {
staticType = expression.staticType;
}
if (parent is MethodInvocation && parent.methodName == expression) {
@@ -106,6 +108,9 @@ class DartUnitHoverComputer {
}
String _computeDocumentation(Element element) {
+ if (element is FieldFormalParameterElement) {
+ element = (element as FieldFormalParameterElement).field;
+ }
if (element is ParameterElement) {
element = element.enclosingElement;
}
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698