pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart - Issue 2681233005: Analysis.getHover should return the field's documentation for field formal parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart

Issue 2681233005: Analysis.getHover should return the field's documentation for field formal parameters. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/computer/computer_hover.dart ('k') | pkg/analysis_server/test/analysis/get_hover_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart

index 43f0fd890ec7fbde5719323f577484fa1a32d07c..0e92c36c30f961861a8980265ccefed327bd7225 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart

@@ -262,7 +262,8 @@ class ArgListContributor extends DartCompletionContributor {

parameterName: name,

parameterType: type);

if (parameter is FieldFormalParameterElement) {

- _setDocumentation(suggestion, parameter.field.documentationComment);

+ _setDocumentation(suggestion, parameter.field?.documentationComment);

+ suggestion.element = convertElement(parameter);

}

suggestions.add(suggestion);

}

« no previous file with comments | « pkg/analysis_server/lib/src/computer/computer_hover.dart ('k') | pkg/analysis_server/test/analysis/get_hover_test.dart » ('j') | no next file with comments »