Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2681233005: Analysis.getHover should return the field's documentation for field formal parameters. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Analysis.getHover should return the field's documentation for field formal parameters. Also return the parameter's element with completion suggestion. R=brianwilkerson@google.com BUG= https://github.com/flutter/flutter-intellij/issues/385 Committed: https://github.com/dart-lang/sdk/commit/663b7f665e63eb9062028022d47dd24c56b789ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -12 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/get_hover_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 1 chunk +30 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-10 00:49:24 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-10 16:03:17 UTC) #2
scheglov
3 years, 10 months ago (2017-02-10 16:49:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
663b7f665e63eb9062028022d47dd24c56b789ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698