Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h

Issue 2681193003: Page load metrics observers cleanup (Closed)
Patch Set: address comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
index 5dca62a4ffc1018e35b30893c9c4f502a3d45b31..19b92c1153753e1f17a4b109bca716604b9682c2 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
@@ -44,13 +44,13 @@ extern const char kHistogramParseBlockedOnScriptLoadSuffix[];
extern const char kHistogramParseDurationSuffix[];
// Byte and request specific histogram suffixes.
-extern const char kRequestsPercentProxied[];
+extern const char kResourcesPercentProxied[];
extern const char kBytesPercentProxied[];
extern const char kBytesCompressionRatio[];
extern const char kBytesInflationPercent[];
-extern const char kNetworkRequests[];
-extern const char kRequestsProxied[];
-extern const char kRequestsNotProxied[];
+extern const char kNetworkResources[];
+extern const char kResourcesProxied[];
+extern const char kResourcesNotProxied[];
extern const char kNetworkBytes[];
extern const char kBytesProxied[];
extern const char kBytesNotProxied[];
@@ -73,9 +73,6 @@ class DataReductionProxyMetricsObserver
const GURL& currently_committed_url,
bool started_in_foreground) override;
ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;
- ObservePolicy OnHidden(
- const page_load_metrics::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& info) override;
ObservePolicy FlushMetricsOnAppEnterBackground(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
@@ -127,11 +124,11 @@ class DataReductionProxyMetricsObserver
// The browser context this navigation is operating in.
content::BrowserContext* browser_context_;
- // The number of requests that used data reduction proxy.
- int num_data_reduction_proxy_requests_;
+ // The number of resources that used data reduction proxy.
+ int num_data_reduction_proxy_resources_;
- // The number of request that did not come from cache.
- int num_network_requests_;
+ // The number of resources that did not come from cache.
+ int num_network_resources_;
// The total content network bytes that the user would have downloaded if they
// were not using data reduction proxy.

Powered by Google App Engine
This is Rietveld 408576698