Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6675)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2681193003: Page load metrics observers cleanup (Closed)
Patch Set: address comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index 47f3cd759f94236371738838fce85bcdbb6c770c..e8a7178e666a0408dfdd35a1dd02dec5c0cf924f 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -482,12 +482,18 @@ TEST_F(CorePageLoadMetricsObserverTest, NewNavigation) {
timing.parse_start.value().InMilliseconds(), 1);
}
-TEST_F(CorePageLoadMetricsObserverTest, BytesCounted) {
+TEST_F(CorePageLoadMetricsObserverTest, BytesAndResourcesCounted) {
NavigateAndCommit(GURL(kDefaultTestUrl));
NavigateAndCommit(GURL(kDefaultTestUrl2));
histogram_tester().ExpectTotalCount(internal::kHistogramTotalBytes, 1);
histogram_tester().ExpectTotalCount(internal::kHistogramNetworkBytes, 1);
histogram_tester().ExpectTotalCount(internal::kHistogramCacheBytes, 1);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramTotalCompletedResources, 1);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramNetworkCompletedResources, 1);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramCacheCompletedResources, 1);
}
TEST_F(CorePageLoadMetricsObserverTest, FirstMeaningfulPaint) {

Powered by Google App Engine
This is Rietveld 408576698