[DevTools] Hide clear button for empty fields

[DevTools] Hide clear button for empty fields

BUG=690325
Review-Url: https://codereview.chromium.org/2681183003
Cr-Commit-Position: refs/heads/master@{#449393}
Committed: https://chromium.googlesource.com/chromium/src/+/c140e50e0f1628e23737fd530e5d280b6335dea3

[eostroukhov, 2017-02-09 18:32:09]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[eostroukhov, 2017-02-09 18:33:12]

eostroukhov@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org, phulce@chromium.org

[commit-bot: I haz the power, 2017-02-09 18:33:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[phulce, 2017-02-09 18:43:10]

much improved experience I like it! :)

https://codereview.chromium.org/2681183003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (right):

https://codereview.chromium.org/2681183003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:628: _updateIfEmpty()
{
not a huge fan of the name, can we specify what we're updating here?
updateEmptyStyles, updateClassesIfEmpty, idk something that makes it clearer why
we're calling it.

[pfeldman, 2017-02-09 18:45:15]

lgtm % nits

https://codereview.chromium.org/2681183003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (right):

https://codereview.chromium.org/2681183003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:628: _updateIfEmpty()
{
+1 _updateEmptyStyles

[eostroukhov, 2017-02-09 18:52:15]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 18:52:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-02-09 18:53:32]

Thank you for the review. Note that I also just included a fix for a minor bug,
don't think it is worth it doing a CR just for that one.

[eostroukhov, 2017-02-09 18:53:39]

The CQ bit was unchecked by eostroukhov@chromium.org

[eostroukhov, 2017-02-09 18:53:42]

The CQ bit was checked by eostroukhov@chromium.org

[eostroukhov, 2017-02-09 18:53:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2681183003/#ps20001
(title: "[DevTools] Hide clear button for empty fields")

[eostroukhov, 2017-02-09 18:53:45]

The CQ bit was checked by eostroukhov@chromium.org

[commit-bot: I haz the power, 2017-02-09 18:53:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 20:25:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486666425239550,
"parent_rev": "468141a302bc1a593c5f9ec5286e858cf3a5f465", "commit_rev":
"c140e50e0f1628e23737fd530e5d280b6335dea3"}

[commit-bot: I haz the power, 2017-02-09 20:27:05]

Description was changed from

==========
[DevTools] Hide clear button for empty fields

BUG=690325
==========

to

==========
[DevTools] Hide clear button for empty fields

BUG=690325

Review-Url: https://codereview.chromium.org/2681183003
Cr-Commit-Position: refs/heads/master@{#449393}
Committed:
https://chromium.googlesource.com/chromium/src/+/c140e50e0f1628e23737fd530e5d...
==========

[commit-bot: I haz the power, 2017-02-09 20:27:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c140e50e0f1628e23737fd530e5d...