Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2681183003: [DevTools] Hide clear button for empty fields (Closed)

Created:
3 years, 10 months ago by eostroukhov
Modified:
3 years, 10 months ago
Reviewers:
phulce, dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Hide clear button for empty fields BUG=690325 Review-Url: https://codereview.chromium.org/2681183003 Cr-Commit-Position: refs/heads/master@{#449393} Committed: https://chromium.googlesource.com/chromium/src/+/c140e50e0f1628e23737fd530e5d280b6335dea3

Patch Set 1 #

Total comments: 2

Patch Set 2 : [DevTools] Hide clear button for empty fields #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 1 4 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
eostroukhov
3 years, 10 months ago (2017-02-09 18:33:12 UTC) #3
phulce
much improved experience I like it! :) https://codereview.chromium.org/2681183003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (right): https://codereview.chromium.org/2681183003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js#newcode628 third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:628: _updateIfEmpty() { ...
3 years, 10 months ago (2017-02-09 18:43:10 UTC) #5
pfeldman
lgtm % nits https://codereview.chromium.org/2681183003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js File third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js (right): https://codereview.chromium.org/2681183003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js#newcode628 third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js:628: _updateIfEmpty() { +1 _updateEmptyStyles
3 years, 10 months ago (2017-02-09 18:45:15 UTC) #6
eostroukhov
Thank you for the review. Note that I also just included a fix for a ...
3 years, 10 months ago (2017-02-09 18:53:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681183003/20001
3 years, 10 months ago (2017-02-09 18:53:57 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 20:27:06 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c140e50e0f1628e23737fd530e5d...

Powered by Google App Engine
This is Rietveld 408576698