Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2681123002: [regexp] Ensure IrregexpExecRaw is passed a flat string (Closed)

Created:
3 years, 10 months ago by jgruber
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Ensure IrregexpExecRaw is passed a flat string BUG=v8:5943 Review-Url: https://codereview.chromium.org/2681123002 Cr-Commit-Position: refs/heads/master@{#43058} Committed: https://chromium.googlesource.com/v8/v8/+/1d3317ff05091937dc56bec83b2278184ee3abb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M src/regexp/jsregexp.cc View 2 chunks +3 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-5943.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
3 years, 10 months ago (2017-02-08 16:12:23 UTC) #4
Yang
On 2017/02/08 16:12:23, jgruber wrote: lgtm.
3 years, 10 months ago (2017-02-09 08:27:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681123002/1
3 years, 10 months ago (2017-02-09 11:22:53 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 11:24:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1d3317ff05091937dc56bec83b2278184ee...

Powered by Google App Engine
This is Rietveld 408576698