Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2681093005: Remove UserPolicyDiskCache; it is not used. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 10 months ago
Reviewers:
emaxx
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove UserPolicyDiskCache; it is not used. BUG=690665 Review-Url: https://codereview.chromium.org/2681093005 Cr-Commit-Position: refs/heads/master@{#449516} Committed: https://chromium.googlesource.com/chromium/src/+/fabbe1317d8d93fad920da7291912b6f74e96175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -244 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/chromeos/policy/user_policy_disk_cache.h View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/chromeos/policy/user_policy_disk_cache.cc View 1 chunk +0 lines, -148 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
jdufault
emaxx@ PTAL. Thanks!
3 years, 10 months ago (2017-02-09 22:36:54 UTC) #12
jdufault
On 2017/02/09 22:36:54, jdufault wrote: > emaxx@ PTAL. Thanks! Oops - I meant UserPolicyDiskCache, not ...
3 years, 10 months ago (2017-02-09 22:37:52 UTC) #14
emaxx
LGTM. Nice catch, thanks for doing this! This code has probably been unused for some ...
3 years, 10 months ago (2017-02-10 00:43:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681093005/1
3 years, 10 months ago (2017-02-10 00:45:15 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 02:17:45 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fabbe1317d8d93fad920da729191...

Powered by Google App Engine
This is Rietveld 408576698