Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2681073003: Clear BlobReader in SW browser_tests on the right thread (Closed)

Created:
3 years, 10 months ago by tzik
Modified:
3 years, 10 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear BlobReader in SW browser_tests on the right thread BlobReader is created on the IO thread and destroyed on the main thread on Service Worker tests. However, BlobReader has BlobDataSnapshot and BlobDataSnapshot has BlobDataItem, which is non-thread safe RefCounted. That implies BlobReader has to be destroyed on IO thread where BlobReader was created on. Review-Url: https://codereview.chromium.org/2681073003 Cr-Commit-Position: refs/heads/master@{#448927} Committed: https://chromium.googlesource.com/chromium/src/+/a79a95466df9d013721167cf2f0c8ba849214207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tzik
PTAL
3 years, 10 months ago (2017-02-08 06:00:08 UTC) #4
horo
lgtm
3 years, 10 months ago (2017-02-08 06:15:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681073003/1
3 years, 10 months ago (2017-02-08 06:27:56 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 07:06:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a79a95466df9d013721167cf2f0c...

Powered by Google App Engine
This is Rietveld 408576698