Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2681063002:
DevTools: Remove @unrestricted from StylesSidebarPane.js (Closed)
|
Created:
3 years, 10 months ago by einbinder Modified:
3 years, 9 months ago Reviewers:
lushnikov CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Remove @unrestricted from StylesSidebarPane.js
BUG=none
Review-Url: https://codereview.chromium.org/2681063002
Cr-Commit-Position: refs/heads/master@{#453857}
Committed: https://chromium.googlesource.com/chromium/src/+/824475890477cf97f9fef981993d628cf3d4a8cb
Patch Set 1 #
Total comments: 3
Patch Set 2 : Don't delete properties #Patch Set 3 : merge #Patch Set 4 : merge #Messages
Total messages: 22 (12 generated)
einbinder@chromium.org changed reviewers: + lushnikov@chromium.org
ptal https://codereview.chromium.org/2681063002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/2681063002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1793: this._prompt = null; This was scary, working with TextPrompt without help from closure. https://codereview.chromium.org/2681063002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:2514: this._originalPropertyText = ''; I am a little concerned about originalPropertyText and _propertyHasBeenEditedIncrementally. We never set _propertyHasBeenEditedIncrementally to false. Maybe there is a bug here? https://codereview.chromium.org/2681063002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:2878: if (!this._isEditingName && this._treeElement.valueElement && valueElement could be null here. It shouldn't be because we are editingName, but I think it is worth the extra check instead of a cast.
lgtm
The CQ bit was checked by einbinder@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by einbinder@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lushnikov@chromium.org Link to the patchset: https://codereview.chromium.org/2681063002/#ps40001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by einbinder@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lushnikov@chromium.org Link to the patchset: https://codereview.chromium.org/2681063002/#ps60001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488342120576590,
"parent_rev": "186f899c6201f18f98e56c640c97430063906d4d", "commit_rev":
"824475890477cf97f9fef981993d628cf3d4a8cb"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: Remove @unrestricted from StylesSidebarPane.js BUG=none ========== to ========== DevTools: Remove @unrestricted from StylesSidebarPane.js BUG=none Review-Url: https://codereview.chromium.org/2681063002 Cr-Commit-Position: refs/heads/master@{#453857} Committed: https://chromium.googlesource.com/chromium/src/+/824475890477cf97f9fef981993d... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/824475890477cf97f9fef981993d... |
