Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2681043002: DevTools: Combine TextPrompt events into UI.TextPrompt.TextChangedEvent (Closed)

Created:
3 years, 10 months ago by einbinder
Modified:
3 years, 10 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Combine TextPrompt events into UI.TextPrompt.TextChangedEvent This patch fires TextChangedEvent whenever the textWithCurrentSuggestion is changed. This prevents clients of text prompt from needing to listen to ItemApplied, ItemAccepted, and input events. BUG=none R=lushnikov Review-Url: https://codereview.chromium.org/2681043002 Cr-Commit-Position: refs/heads/master@{#448892} Committed: https://chromium.googlesource.com/chromium/src/+/5903317ed90e3203ce2ead7a9ddda5ef0429b0d2

Patch Set 1 #

Patch Set 2 : leave comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -27 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 3 chunks +5 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 5 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
einbinder
ptal
3 years, 10 months ago (2017-02-08 01:05:47 UTC) #1
lushnikov
lgtm
3 years, 10 months ago (2017-02-08 01:47:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681043002/20001
3 years, 10 months ago (2017-02-08 01:57:29 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 03:28:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5903317ed90e3203ce2ead7a9ddd...

Powered by Google App Engine
This is Rietveld 408576698