Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2681013002: Add TEAM/COMPONENT (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org, wfh+watch_chromium.org, abarth-chromium, blink-reviews, tracing+reviews_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TEAM/COMPONENT BUG=679905 Review-Url: https://codereview.chromium.org/2681013002 Cr-Commit-Position: refs/heads/master@{#449680} Committed: https://chromium.googlesource.com/chromium/src/+/922b98ba5c004ba8b4273c2530aedf9281f6bdff

Patch Set 1 #

Patch Set 2 : update team compo #

Total comments: 4

Patch Set 3 : update team/compo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M base/allocator/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M base/trace_event/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/instrumentation/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/binary_size/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/memory_inspector/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-07 23:57:19 UTC) #2
lpy
On 2017/02/07 23:57:19, ymzhang1 wrote: > Hello, > > We are adding COMPONENT/TEAM information into ...
3 years, 10 months ago (2017-02-08 00:06:57 UTC) #3
ymzhang1
On 2017/02/08 00:06:57, lpy wrote: > On 2017/02/07 23:57:19, ymzhang1 wrote: > > Hello, > ...
3 years, 10 months ago (2017-02-08 00:16:34 UTC) #4
Primiano Tucci (use gerrit)
LGTM with comment addressed. https://codereview.chromium.org/2681013002/diff/20001/base/allocator/OWNERS File base/allocator/OWNERS (right): https://codereview.chromium.org/2681013002/diff/20001/base/allocator/OWNERS#newcode7 base/allocator/OWNERS:7: # COMPONENT: Manifest What is ...
3 years, 10 months ago (2017-02-08 16:33:00 UTC) #5
ymzhang1
https://codereview.chromium.org/2681013002/diff/20001/base/allocator/OWNERS File base/allocator/OWNERS (right): https://codereview.chromium.org/2681013002/diff/20001/base/allocator/OWNERS#newcode7 base/allocator/OWNERS:7: # COMPONENT: Manifest On 2017/02/08 16:33:00, Primiano Tucci wrote: ...
3 years, 10 months ago (2017-02-10 00:33:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681013002/40001
3 years, 10 months ago (2017-02-10 18:05:29 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 19:06:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/922b98ba5c004ba8b4273c2530ae...

Powered by Google App Engine
This is Rietveld 408576698