memory-infra: The client library

memory-infra: The client library

This implements MemoryDumpManagerDelegate (MDMD). MDMD is just a
bridge between MemoryDumpManager and the Coordinator service, hiding
mojo details from MemoryDumpManager.

The next CL will put everything together and delete the old code.

A prototype of the end product: https://codereview.chromium.org/2571823002

BUG=679830
Review-Url: https://codereview.chromium.org/2681003006
Cr-Commit-Position: refs/heads/master@{#449374}
Committed: https://chromium.googlesource.com/chromium/src/+/7ca40bc859221e9ce128da52ca664d35d2781a26

[chiniforooshan, 2017-02-09 16:51:58]

chiniforooshan@chromium.org changed reviewers:
+ primiano@chromium.org

[chiniforooshan, 2017-02-09 16:51:59]

PTAL

[Primiano Tucci (use gerrit), 2017-02-09 18:19:42]

LGTM

https://codereview.chromium.org/2681003006/diff/1/services/memory_instrumenta...
File
services/memory_instrumentation/public/cpp/memory_dump_manager_delegate_impl.h
(right):

https://codereview.chromium.org/2681003006/diff/1/services/memory_instrumenta...
services/memory_instrumentation/public/cpp/memory_dump_manager_delegate_impl.h:24:
// Use to bind to a coordinator in the same process.
nit: add a newline

https://codereview.chromium.org/2681003006/diff/1/services/memory_instrumenta...
services/memory_instrumentation/public/cpp/memory_dump_manager_delegate_impl.h:29:
// The memory dump manager calls this.
nit: newline here also

maybe say: base::trace_event::MemoryDumpManager just to be clear because right
now we are having managers everywhere :)

[chiniforooshan, 2017-02-09 18:29:33]

Thanks.

https://codereview.chromium.org/2681003006/diff/1/services/memory_instrumenta...
File
services/memory_instrumentation/public/cpp/memory_dump_manager_delegate_impl.h
(right):

https://codereview.chromium.org/2681003006/diff/1/services/memory_instrumenta...
services/memory_instrumentation/public/cpp/memory_dump_manager_delegate_impl.h:24:
// Use to bind to a coordinator in the same process.
On 2017/02/09 18:19:42, Primiano Tucci wrote:
> nit: add a newline

Done.

https://codereview.chromium.org/2681003006/diff/1/services/memory_instrumenta...
services/memory_instrumentation/public/cpp/memory_dump_manager_delegate_impl.h:29:
// The memory dump manager calls this.
On 2017/02/09 18:19:42, Primiano Tucci wrote:
> nit: newline here also
> 
> maybe say: base::trace_event::MemoryDumpManager just to be clear because right
> now we are having managers everywhere :)

Done.

[chiniforooshan, 2017-02-09 18:29:45]

The CQ bit was checked by chiniforooshan@chromium.org

[chiniforooshan, 2017-02-09 18:29:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/2681003006/#ps20001
(title: "review")

[commit-bot: I haz the power, 2017-02-09 18:30:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 19:31:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486664985951080,
"parent_rev": "fad042aa5ace0033293dbbddcd7204fafccd4bdc", "commit_rev":
"7ca40bc859221e9ce128da52ca664d35d2781a26"}

[commit-bot: I haz the power, 2017-02-09 19:34:57]

Description was changed from

==========
memory-infra: The client library

This implements MemoryDumpManagerDelegate (MDMD). MDMD is just a
bridge between MemoryDumpManager and the Coordinator service, hiding
mojo details from MemoryDumpManager.

The next CL will put everything together and delete the old code.

A prototype of the end product: https://codereview.chromium.org/2571823002

BUG=679830
==========

to

==========
memory-infra: The client library

This implements MemoryDumpManagerDelegate (MDMD). MDMD is just a
bridge between MemoryDumpManager and the Coordinator service, hiding
mojo details from MemoryDumpManager.

The next CL will put everything together and delete the old code.

A prototype of the end product: https://codereview.chromium.org/2571823002

BUG=679830

Review-Url: https://codereview.chromium.org/2681003006
Cr-Commit-Position: refs/heads/master@{#449374}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ca40bc859221e9ce128da52ca66...
==========

[commit-bot: I haz the power, 2017-02-09 19:34:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7ca40bc859221e9ce128da52ca66...