Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2680993002: Remove non-MD test coverage from TrayUserTest (Closed)

Created:
3 years, 10 months ago by mohsen
Modified:
3 years, 10 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-MD test coverage from TrayUserTest Removed test coverage for the separator that only exists in non-MD TrayUser. BUG=685837 TEST=TrayUserTest.* in ash_unittests Review-Url: https://codereview.chromium.org/2680993002 Cr-Commit-Position: refs/heads/master@{#448856} Committed: https://chromium.googlesource.com/chromium/src/+/c62b316ce3138b7db046f25cf0d7cd7f5901dcf5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -31 lines) Patch
M ash/common/system/user/tray_user_unittest.cc View 11 chunks +3 lines, -31 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mohsen
Please take a look...
3 years, 10 months ago (2017-02-07 23:40:06 UTC) #3
tdanderson
LGTM
3 years, 10 months ago (2017-02-08 00:41:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680993002/1
3 years, 10 months ago (2017-02-08 02:03:51 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 02:11:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c62b316ce3138b7db046f25cf0d7...

Powered by Google App Engine
This is Rietveld 408576698