Log when PreventDefaulting event forced uncancellable.

Log when PreventDefaulting event forced uncancellable.

Logs to JS console and records a use counter when an uncancellable event has
preventDefault called on it, for the main thread unresponsiveness scrolling
intervention, as well as in the general case.

Also migrates the existing forced passive document level listeners warning to
use the InterventionMessageSource.

Use Counters added:
UncancellableTouchEventPreventDefaulted
UncancellableTouchEventDueToMainThreadResponsivenessPreventDefaulted

BUG=599609
TEST=TouchEventTest

Review-Url: https://codereview.chromium.org/2680973010
Cr-Commit-Position: refs/heads/master@{#449987}
Committed: https://chromium.googlesource.com/chromium/src/+/725e6577e9c3d03aeb9dea5851422813ec6e84e5

[tdresser, 2017-02-09 16:46:57]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 16:47:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 16:49:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 16:49:48]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[tdresser, 2017-02-09 16:57:11]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 16:57:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 17:11:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 17:11:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdresser, 2017-02-09 20:11:01]

tdresser@chromium.org changed reviewers:
+ bokan@chromium.org

[tdresser, 2017-02-09 20:11:02]

Bokan@, PTAL.

Having a hard time nailing down why the Windows build is failing here.

E:\b\c\b\win_clang\src\third_party\WebKit\Source\core\loader\EmptyClients.cpp(49,6):
 error: 'blink::fillWithEmptyClients' redeclared without 'dllimport' attribute:
'dllexport' attribute added [-Werror,-Winconsistent-dllimport]
void fillWithEmptyClients(Page::PageClients& pageClients) {

TextControlElementTest.cpp is in the same target, and also uses EmptyClients...
Any thoughts?

[bokan, 2017-02-10 00:24:06]

lgtm with changes

https://codereview.chromium.org/2680973010/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/TouchEvent.cpp (right):

https://codereview.chromium.org/2680973010/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/TouchEvent.cpp:282: warningMessage =
"Ignored attempt to cancel a " + type() +
Just checking - you intend for the ForcedNonBlockingDueToFling to use this
warning too (and not be counted in "ForcedNonBlocking" for the use counter)?

https://codereview.chromium.org/2680973010/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/TouchEventTest.cpp (right):

https://codereview.chromium.org/2680973010/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/TouchEventTest.cpp:9: #include
"core/loader/EmptyClients.cpp"
Methinks you meant EmptyClients.h :)

[bokan, 2017-02-10 00:24:35]

On 2017/02/10 00:24:06, bokan wrote:
> lgtm with changes
Change, rather, and confirmation.

[tdresser, 2017-02-10 13:24:56]

tdresser@chromium.org changed reviewers:
+ mpearson@google.com

[tdresser, 2017-02-10 13:24:57]

+mpearson@ for histograms.xml changes.

https://codereview.chromium.org/2680973010/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/TouchEvent.cpp (right):

https://codereview.chromium.org/2680973010/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/TouchEvent.cpp:282: warningMessage =
"Ignored attempt to cancel a " + type() +
On 2017/02/10 00:24:06, bokan wrote:
> Just checking - you intend for the ForcedNonBlockingDueToFling to use this
> warning too (and not be counted in "ForcedNonBlocking" for the use counter)?

We consider the "due to fling case" to be equivalent to other cases where we
force the event non blocking because we're mid scroll, so we don't call it out
separately.

https://codereview.chromium.org/2680973010/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/TouchEventTest.cpp (right):

https://codereview.chromium.org/2680973010/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/TouchEventTest.cpp:9: #include
"core/loader/EmptyClients.cpp"
On 2017/02/10 00:24:06, bokan wrote:
> Methinks you meant EmptyClients.h :)

GOSH DARN IT.
Thanks.

[tdresser, 2017-02-10 13:29:03]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 13:29:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 15:33:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 15:33:55]

Dry run: This issue passed the CQ dry run.

[bokan, 2017-02-10 15:36:16]

https://codereview.chromium.org/2680973010/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/TouchEvent.cpp (right):

https://codereview.chromium.org/2680973010/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/TouchEvent.cpp:282: warningMessage =
"Ignored attempt to cancel a " + type() +
On 2017/02/10 13:24:57, tdresser wrote:
> On 2017/02/10 00:24:06, bokan wrote:
> > Just checking - you intend for the ForcedNonBlockingDueToFling to use this
> > warning too (and not be counted in "ForcedNonBlocking" for the use counter)?
> 
> We consider the "due to fling case" to be equivalent to other cases where we
> force the event non blocking because we're mid scroll, so we don't call it out
> separately.

Acknowledged.

[Mark P, 2017-02-10 22:58:04]

mpearson@chromium.org changed reviewers:
+ mpearson@chromium.org

[Mark P, 2017-02-10 22:58:05]

histograms.xml lgtm, though you'll need to resync and revise the use counter
numbers before submitting.

--mark

[tdresser, 2017-02-13 15:24:17]

The CQ bit was checked by tdresser@chromium.org

[tdresser, 2017-02-13 15:24:18]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org,
mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/2680973010/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-13 15:24:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 17:19:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486999457908350,
"parent_rev": "7250e1ab8f60d4a7ad8644c11ed0576f2c4f34b1", "commit_rev":
"725e6577e9c3d03aeb9dea5851422813ec6e84e5"}

[commit-bot: I haz the power, 2017-02-13 17:20:30]

Description was changed from

==========
Log when PreventDefaulting event forced uncancellable.

Logs to JS console and records a use counter when an uncancellable event has
preventDefault called on it, for the main thread unresponsiveness scrolling
intervention, as well as in the general case.

Also migrates the existing forced passive document level listeners warning to
use the InterventionMessageSource.

Use Counters added:
UncancellableTouchEventPreventDefaulted
UncancellableTouchEventDueToMainThreadResponsivenessPreventDefaulted

BUG=599609
TEST=TouchEventTest
==========

to

==========
Log when PreventDefaulting event forced uncancellable.

Logs to JS console and records a use counter when an uncancellable event has
preventDefault called on it, for the main thread unresponsiveness scrolling
intervention, as well as in the general case.

Also migrates the existing forced passive document level listeners warning to
use the InterventionMessageSource.

Use Counters added:
UncancellableTouchEventPreventDefaulted
UncancellableTouchEventDueToMainThreadResponsivenessPreventDefaulted

BUG=599609
TEST=TouchEventTest

Review-Url: https://codereview.chromium.org/2680973010
Cr-Commit-Position: refs/heads/master@{#449987}
Committed:
https://chromium.googlesource.com/chromium/src/+/725e6577e9c3d03aeb9dea585142...
==========

[commit-bot: I haz the power, 2017-02-13 17:20:31]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/725e6577e9c3d03aeb9dea585142...