Mojo EDK: Add safe process connection API

Mojo EDK: Add safe process connection API

Replaces ad hoc ChildProcessLaunched etc functions and "child tokens"
with a scoping PendingProcessConnection object. This encapsulates the
concept of a process to which we intend to connect (e.g. so we can start
vending message pipe handles for it) but which may not yet be reachable,
and it ensures that any associated resources are reliably cleaned
up in the event that we never actually connect to the process.

This API also begins an intentional departure from the now-inaccurate
naming conventions of "parent" and "child" used at the EDK layer to
refer to some relative process relationships.

BUG=682794
Review-Url: https://codereview.chromium.org/2680973006
Cr-Commit-Position: refs/heads/master@{#449457}
Committed: https://chromium.googlesource.com/chromium/src/+/1039b82bdad1ce37bd6716636e918f475ed50d13

[Ken Rockot(use gerrit already), 2017-02-08 23:16:09]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 23:16:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-02-08 23:17:42]

Description was changed from

==========
Mojo EDK: Add safe process connection API

Replaces ad hoc ChildProcessLaunched etc functions with a scoping
PendingProcessConnection object. This encapsulates the concept of
a process to which we intend to connect (so we can start vending
message pipe handles for it, etc) but which is not yet reachable,
and it ensures that any associated resources can be reliably cleaned
up in the event that we never reach the remote process.

This API also begins an intentional departure from the now-inaccurate
naming conventions of "parent" and "child" used at the EDK layer to
refer to relative process relationships.

BUG=682794
==========

to

==========
Mojo EDK: Add safe process connection API

Replaces ad hoc ChildProcessLaunched etc functions and "child tokens"
with a scoping PendingProcessConnection object. This encapsulates the
concept of a process to which we intend to connect (e.g. so we can start
vending message pipe handles for it) but which is not yet reachable,
and it ensures that any associated resources are be reliably cleaned
up in the event that we never actually connect to the process.

This API also begins an intentional departure from the now-inaccurate
naming conventions of "parent" and "child" used at the EDK layer to
refer to some relative process relationships.

BUG=682794
==========

[Ken Rockot(use gerrit already), 2017-02-08 23:19:56]

rockot@chromium.org changed reviewers:
+ sammc@chromium.org

[Ken Rockot(use gerrit already), 2017-02-08 23:19:56]

Sam PTAL

[Ken Rockot(use gerrit already), 2017-02-08 23:24:34]

On 2017/02/08 at 23:19:56, Ken Rockot wrote:
> Sam PTAL

(specifically at //mojo and the various bits of code you've written - NaCl
stuff, service utility process host, etc)

[commit-bot: I haz the power, 2017-02-08 23:34:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:34:48]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-02-08 23:36:56]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 23:37:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 00:03:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 00:03:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-02-09 00:31:18]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 00:32:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-02-09 01:34:34]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 01:35:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-02-09 02:53:21]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 02:53:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-02-09 05:38:47]

lgtm

https://codereview.chromium.org/2680973006/diff/1/content/browser/child_proce...
File content/browser/child_process_launcher.cc (right):

https://codereview.chromium.org/2680973006/diff/1/content/browser/child_proce...
content/browser/child_process_launcher.cc:89: pending_connection_.reset();
Can we clear this unconditionally?

https://codereview.chromium.org/2680973006/diff/1/mojo/edk/embedder/pending_p...
File mojo/edk/embedder/pending_process_connection.h (right):

https://codereview.chromium.org/2680973006/diff/1/mojo/edk/embedder/pending_p...
mojo/edk/embedder/pending_process_connection.h:53: //    
mojo::edk::InitChild(std::move(client_channel_handle));
Still mojo::edk::SetParentPipeHandle()?

https://codereview.chromium.org/2680973006/diff/1/remoting/host/win/wts_sessi...
File remoting/host/win/wts_session_process_delegate.cc (right):

https://codereview.chromium.org/2680973006/diff/1/remoting/host/win/wts_sessi...
remoting/host/win/wts_session_process_delegate.cc:394:
process_connection_.reset(new mojo::edk::PendingProcessConnection);
process_connection_ = base::MakeUnique<mojo::edk::PendingProcessConnection>();

[Ken Rockot(use gerrit already), 2017-02-09 06:01:22]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2017-02-09 06:01:58]

https://codereview.chromium.org/2680973006/diff/1/content/browser/child_proce...
File content/browser/child_process_launcher.cc (right):

https://codereview.chromium.org/2680973006/diff/1/content/browser/child_proce...
content/browser/child_process_launcher.cc:89: pending_connection_.reset();
On 2017/02/09 at 05:38:47, Sam McNally wrote:
> Can we clear this unconditionally?

Sure, done

https://codereview.chromium.org/2680973006/diff/1/mojo/edk/embedder/pending_p...
File mojo/edk/embedder/pending_process_connection.h (right):

https://codereview.chromium.org/2680973006/diff/1/mojo/edk/embedder/pending_p...
mojo/edk/embedder/pending_process_connection.h:53: //    
mojo::edk::InitChild(std::move(client_channel_handle));
On 2017/02/09 at 05:38:47, Sam McNally wrote:
> Still mojo::edk::SetParentPipeHandle()?

Oops, done

https://codereview.chromium.org/2680973006/diff/1/remoting/host/win/wts_sessi...
File remoting/host/win/wts_session_process_delegate.cc (right):

https://codereview.chromium.org/2680973006/diff/1/remoting/host/win/wts_sessi...
remoting/host/win/wts_session_process_delegate.cc:394:
process_connection_.reset(new mojo::edk::PendingProcessConnection);
On 2017/02/09 at 05:38:47, Sam McNally wrote:
> process_connection_ = base::MakeUnique<mojo::edk::PendingProcessConnection>();

done

[commit-bot: I haz the power, 2017-02-09 06:02:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-02-09 06:49:07]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-02-09 06:49:09]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-02-09 06:49:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org
Link to the patchset: https://codereview.chromium.org/2680973006/#ps100001
(title: ".")

[commit-bot: I haz the power, 2017-02-09 06:49:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 06:57:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 06:57:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2017-02-09 07:07:59]

rockot@chromium.org changed reviewers:
+ jam@chromium.org

[Ken Rockot(use gerrit already), 2017-02-09 07:07:59]

rockot@chromium.org changed reviewers:
+ jam@chromium.org

[Ken Rockot(use gerrit already), 2017-02-09 07:08:00]

+jam for content and chrome

[Ken Rockot(use gerrit already), 2017-02-09 07:08:00]

+jam for content and chrome

[Ken Rockot(use gerrit already), 2017-02-09 07:20:21]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 07:20:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 07:28:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 07:28:11]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Ken Rockot(use gerrit already), 2017-02-09 08:01:54]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 08:02:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-02-09 08:06:11]

Patchset #7 (id:120001) has been deleted

[Ken Rockot(use gerrit already), 2017-02-09 08:06:16]

Patchset #6 (id:100001) has been deleted

[Ken Rockot(use gerrit already), 2017-02-09 08:06:24]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2017-02-09 08:06:29]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-02-09 08:06:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-02-09 08:06:34]

Patchset #2 (id:40001) has been deleted

[Ken Rockot(use gerrit already), 2017-02-09 08:06:39]

Patchset #2 (id:60001) has been deleted

[Ken Rockot(use gerrit already), 2017-02-09 08:06:44]

Patchset #2 (id:80001) has been deleted

[Ken Rockot(use gerrit already), 2017-02-09 08:06:51]

Patchset #2 (id:140001) has been deleted

[Ken Rockot(use gerrit already), 2017-02-09 08:08:14]

Description was changed from

==========
Mojo EDK: Add safe process connection API

Replaces ad hoc ChildProcessLaunched etc functions and "child tokens"
with a scoping PendingProcessConnection object. This encapsulates the
concept of a process to which we intend to connect (e.g. so we can start
vending message pipe handles for it) but which is not yet reachable,
and it ensures that any associated resources are be reliably cleaned
up in the event that we never actually connect to the process.

This API also begins an intentional departure from the now-inaccurate
naming conventions of "parent" and "child" used at the EDK layer to
refer to some relative process relationships.

BUG=682794
==========

to

==========
Mojo EDK: Add safe process connection API

Replaces ad hoc ChildProcessLaunched etc functions and "child tokens"
with a scoping PendingProcessConnection object. This encapsulates the
concept of a process to which we intend to connect (e.g. so we can start
vending message pipe handles for it) but which may not yet be reachable,
and it ensures that any associated resources are be reliably cleaned
up in the event that we never actually connect to the process.

This API also begins an intentional departure from the now-inaccurate
naming conventions of "parent" and "child" used at the EDK layer to
refer to some relative process relationships.

BUG=682794
==========

[commit-bot: I haz the power, 2017-02-09 08:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 08:18:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2017-02-09 08:23:53]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 08:24:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-02-09 08:31:54]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2017-02-09 08:32:07]

Patchset #2 (id:160001) has been deleted

[Ken Rockot(use gerrit already), 2017-02-09 08:32:12]

Patchset #2 (id:180001) has been deleted

[commit-bot: I haz the power, 2017-02-09 08:32:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 09:34:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 09:34:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-02-09 17:22:55]

lgtm

[joedow, 2017-02-09 20:38:29]

joedow@chromium.org changed reviewers:
+ joedow@chromium.org

[joedow, 2017-02-09 20:38:30]

remoting lgtm

[Ken Rockot(use gerrit already), 2017-02-09 21:17:12]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 21:17:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-02-09 21:52:33]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-02-09 21:52:35]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-02-09 21:52:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org,
jam@chromium.org, joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/2680973006/#ps220001
(title: ".")

[commit-bot: I haz the power, 2017-02-09 21:52:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-02-09 22:53:28]

Description was changed from

==========
Mojo EDK: Add safe process connection API

Replaces ad hoc ChildProcessLaunched etc functions and "child tokens"
with a scoping PendingProcessConnection object. This encapsulates the
concept of a process to which we intend to connect (e.g. so we can start
vending message pipe handles for it) but which may not yet be reachable,
and it ensures that any associated resources are be reliably cleaned
up in the event that we never actually connect to the process.

This API also begins an intentional departure from the now-inaccurate
naming conventions of "parent" and "child" used at the EDK layer to
refer to some relative process relationships.

BUG=682794
==========

to

==========
Mojo EDK: Add safe process connection API

Replaces ad hoc ChildProcessLaunched etc functions and "child tokens"
with a scoping PendingProcessConnection object. This encapsulates the
concept of a process to which we intend to connect (e.g. so we can start
vending message pipe handles for it) but which may not yet be reachable,
and it ensures that any associated resources are reliably cleaned
up in the event that we never actually connect to the process.

This API also begins an intentional departure from the now-inaccurate
naming conventions of "parent" and "child" used at the EDK layer to
refer to some relative process relationships.

BUG=682794
==========

[commit-bot: I haz the power, 2017-02-09 23:19:52]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1486677155740240,
"parent_rev": "a9f8c122c9dab66d891bdc9731da47e4bb49cbdf", "commit_rev":
"1039b82bdad1ce37bd6716636e918f475ed50d13"}

[commit-bot: I haz the power, 2017-02-09 23:20:28]

Description was changed from

==========
Mojo EDK: Add safe process connection API

Replaces ad hoc ChildProcessLaunched etc functions and "child tokens"
with a scoping PendingProcessConnection object. This encapsulates the
concept of a process to which we intend to connect (e.g. so we can start
vending message pipe handles for it) but which may not yet be reachable,
and it ensures that any associated resources are reliably cleaned
up in the event that we never actually connect to the process.

This API also begins an intentional departure from the now-inaccurate
naming conventions of "parent" and "child" used at the EDK layer to
refer to some relative process relationships.

BUG=682794
==========

to

==========
Mojo EDK: Add safe process connection API

Replaces ad hoc ChildProcessLaunched etc functions and "child tokens"
with a scoping PendingProcessConnection object. This encapsulates the
concept of a process to which we intend to connect (e.g. so we can start
vending message pipe handles for it) but which may not yet be reachable,
and it ensures that any associated resources are reliably cleaned
up in the event that we never actually connect to the process.

This API also begins an intentional departure from the now-inaccurate
naming conventions of "parent" and "child" used at the EDK layer to
refer to some relative process relationships.

BUG=682794

Review-Url: https://codereview.chromium.org/2680973006
Cr-Commit-Position: refs/heads/master@{#449457}
Committed:
https://chromium.googlesource.com/chromium/src/+/1039b82bdad1ce37bd6716636e91...
==========

[commit-bot: I haz the power, 2017-02-09 23:20:33]

Committed patchset #3 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/1039b82bdad1ce37bd6716636e91...