[stubs] Implement binary-search descriptor lookup in CSA

[stubs] Implement binary-search descriptor lookup in CSA

And use it to avoid runtime calls when there are too many properties
for linear searching.
The threshold of 32 was chosen by experimentation.

Review-Url: https://codereview.chromium.org/2680973002
Cr-Commit-Position: refs/heads/master@{#43078}
Committed: https://chromium.googlesource.com/v8/v8/+/6aea9de25419da07b1588d96cdeeb4546a5eade5

[Jakob Kummerow, 2017-02-07 23:26:53]

jkummerow@chromium.org changed reviewers:
+ ishell@chromium.org

[Jakob Kummerow, 2017-02-07 23:26:53]

PTAL.

[Jakob Kummerow, 2017-02-07 23:39:01]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 23:39:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 23:44:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 23:44:41]

Dry run: Try jobs failed on following builders:
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)

[Jakob Kummerow, 2017-02-08 07:28:07]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 07:28:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 07:50:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 07:50:29]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-02-09 23:52:07]

lgtm

https://codereview.chromium.org/2680973002/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2680973002/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:4861: Node* entry =
DescriptorArrayGetKey(descriptors, sort_index);
Maybe s/entry/current_name/ ?

[Jakob Kummerow, 2017-02-10 00:50:57]

Thanks, landing.

https://codereview.chromium.org/2680973002/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2680973002/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:4861: Node* entry =
DescriptorArrayGetKey(descriptors, sort_index);
On 2017/02/09 23:52:07, Igor Sheludko wrote:
> Maybe s/entry/current_name/ ?

Done.

[Jakob Kummerow, 2017-02-10 00:51:02]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-02-10 00:51:03]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2680973002/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2017-02-10 00:51:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 00:53:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 00:54:00]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20736)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/20786)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)

[Jakob Kummerow, 2017-02-10 01:16:32]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-02-10 01:16:32]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2680973002/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2017-02-10 01:16:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 01:41:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486689392104250,
"parent_rev": "4f4da1f87d45925d8546b755baaf3f1140a4f8b3", "commit_rev":
"6aea9de25419da07b1588d96cdeeb4546a5eade5"}

[commit-bot: I haz the power, 2017-02-10 01:41:05]

Description was changed from

==========
[stubs] Implement binary-search descriptor lookup in CSA

And use it to avoid runtime calls when there are too many properties
for linear searching.
The threshold of 32 was chosen by experimentation.
==========

to

==========
[stubs] Implement binary-search descriptor lookup in CSA

And use it to avoid runtime calls when there are too many properties
for linear searching.
The threshold of 32 was chosen by experimentation.

Review-Url: https://codereview.chromium.org/2680973002
Cr-Commit-Position: refs/heads/master@{#43078}
Committed:
https://chromium.googlesource.com/v8/v8/+/6aea9de25419da07b1588d96cdeeb4546a5...
==========

[commit-bot: I haz the power, 2017-02-10 01:41:06]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/6aea9de25419da07b1588d96cdeeb4546a5...