third_party/WebKit/Source/core/dom/DOMURL.h - Issue 2680933005: Make static KURLs thread safe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMURL.h

Issue 2680933005: Make static KURLs thread safe

Patch Set: :/ Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DOMURL.h

diff --git a/third_party/WebKit/Source/core/dom/DOMURL.h b/third_party/WebKit/Source/core/dom/DOMURL.h

index 1dccfa4fd2a3eb93544bb627ccc3a415499fe9f2..2a518c5f64566f7ce29846316998c70b9adcc6c7 100644

--- a/third_party/WebKit/Source/core/dom/DOMURL.h

+++ b/third_party/WebKit/Source/core/dom/DOMURL.h

@@ -48,7 +48,8 @@ class DOMURL final : public GarbageCollectedFinalized<DOMURL>,

public:

static DOMURL* create(const String& url, ExceptionState& exceptionState) {

- return new DOMURL(url, blankURL(), exceptionState);

+ return new DOMURL(url, KURL(ParsedURLString, kAboutBlankUrl),

esprehn 2017/02/15 02:05:17 it seems pretty bad to parse about:blank inside ev

Charlie Harrison 2017/02/15 02:44:03 OK, I will think of a redesign.

+ exceptionState);

}

static DOMURL* create(const String& url,

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/DOMURL.cpp » ('j') | no next file with comments »