Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: third_party/WebKit/Source/core/dom/DOMURL.h

Issue 2680933005: Make static KURLs thread safe
Patch Set: :/ Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/DOMURL.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Motorola Mobility Inc. 3 * Copyright (C) 2012 Motorola Mobility Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 30 matching lines...) Expand all
41 class URLRegistrable; 41 class URLRegistrable;
42 class URLSearchParams; 42 class URLSearchParams;
43 43
44 class DOMURL final : public GarbageCollectedFinalized<DOMURL>, 44 class DOMURL final : public GarbageCollectedFinalized<DOMURL>,
45 public ScriptWrappable, 45 public ScriptWrappable,
46 public DOMURLUtils { 46 public DOMURLUtils {
47 DEFINE_WRAPPERTYPEINFO(); 47 DEFINE_WRAPPERTYPEINFO();
48 48
49 public: 49 public:
50 static DOMURL* create(const String& url, ExceptionState& exceptionState) { 50 static DOMURL* create(const String& url, ExceptionState& exceptionState) {
51 return new DOMURL(url, blankURL(), exceptionState); 51 return new DOMURL(url, KURL(ParsedURLString, kAboutBlankUrl),
esprehn 2017/02/15 02:05:17 it seems pretty bad to parse about:blank inside ev
Charlie Harrison 2017/02/15 02:44:03 OK, I will think of a redesign.
52 exceptionState);
52 } 53 }
53 54
54 static DOMURL* create(const String& url, 55 static DOMURL* create(const String& url,
55 const String& base, 56 const String& base,
56 ExceptionState& exceptionState) { 57 ExceptionState& exceptionState) {
57 return new DOMURL(url, KURL(KURL(), base), exceptionState); 58 return new DOMURL(url, KURL(KURL(), base), exceptionState);
58 } 59 }
59 ~DOMURL(); 60 ~DOMURL();
60 61
61 CORE_EXPORT static String createPublicURL(ExecutionContext*, 62 CORE_EXPORT static String createPublicURL(ExecutionContext*,
(...skipping 21 matching lines...) Expand all
83 void updateSearchParams(const String&); 84 void updateSearchParams(const String&);
84 85
85 KURL m_url; 86 KURL m_url;
86 String m_input; 87 String m_input;
87 WeakMember<URLSearchParams> m_searchParams; 88 WeakMember<URLSearchParams> m_searchParams;
88 }; 89 };
89 90
90 } // namespace blink 91 } // namespace blink
91 92
92 #endif // DOMURL_h 93 #endif // DOMURL_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/DOMURL.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698