Fixes bugs in cursor handling

Fixes bugs in cursor handling

. CURSOR_NULL on ozone seems to mean leave the last cursor. So, this
  change makes sure we use POINTER rather than CURSOR_NULL.
. aura sets the cursor on the root window, which means mus needs to
  pick up the cursor from the root. I'm not particularly thrilled
  about this, but changing mus is a lot more straightforward than
  changing aura.

BUG=689126
TEST=covered by tests
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2680883002
Cr-Commit-Position: refs/heads/master@{#448690}
Committed: https://chromium.googlesource.com/chromium/src/+/adb99b98e9271ed418fbc941852f5547b0d5d59c

[sky, 2017-02-07 18:17:50]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 18:18:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-02-07 18:35:58]

lgtm

one thing i'm worrying about here is that there's a bunch of places in the
current code where we set a null cursor. are those just latent landmines now?

[sky, 2017-02-07 18:45:07]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-02-07 18:45:11]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-02-07 18:45:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-02-07 18:45:58]

I suspect so. It may be this never manifests in practice because the
only time we use a null cursor is when we explicitly hide the cursor,
so you don't notice it. I'm speculating here.

  -Scott

On Tue, Feb 7, 2017 at 10:35 AM,  <erg@chromium.org> wrote:
> lgtm
>
> one thing i'm worrying about here is that there's a bunch of places in the
> current code where we set a null cursor. are those just latent landmines
> now?
>
> https://codereview.chromium.org/2680883002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-02-07 19:22:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486493111368970, "parent_rev":
"81a6df48520904f38fef52dd165dc24e5cbf95e4", "commit_rev":
"adb99b98e9271ed418fbc941852f5547b0d5d59c"}

[commit-bot: I haz the power, 2017-02-07 19:23:16]

Description was changed from

==========
Fixes bugs in cursor handling

. CURSOR_NULL on ozone seems to mean leave the last cursor. So, this
  change makes sure we use POINTER rather than CURSOR_NULL.
. aura sets the cursor on the root window, which means mus needs to
  pick up the cursor from the root. I'm not particularly thrilled
  about this, but changing mus is a lot more straightforward than
  changing aura.

BUG=689126
TEST=covered by tests
R=erg@chromium.org
==========

to

==========
Fixes bugs in cursor handling

. CURSOR_NULL on ozone seems to mean leave the last cursor. So, this
  change makes sure we use POINTER rather than CURSOR_NULL.
. aura sets the cursor on the root window, which means mus needs to
  pick up the cursor from the root. I'm not particularly thrilled
  about this, but changing mus is a lot more straightforward than
  changing aura.

BUG=689126
TEST=covered by tests
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2680883002
Cr-Commit-Position: refs/heads/master@{#448690}
Committed:
https://chromium.googlesource.com/chromium/src/+/adb99b98e9271ed418fbc941852f...
==========

[commit-bot: I haz the power, 2017-02-07 19:23:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/adb99b98e9271ed418fbc941852f...