Add UMA stats for open and fix memory leak

Add UMA stats to track down issues with opening "high latency" (aka linear) audio input streams on Windows and fix memory leak that appears to have been there for a long while.

BUG=684741, 689976
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2680873002
Cr-Commit-Position: refs/heads/master@{#449359}
Committed: https://chromium.googlesource.com/chromium/src/+/3234f6bb6cfd0343aac4755271f2b8697a8cde49

[tommi (sloooow) - chröme, 2017-02-07 17:24:12]

Description was changed from

==========
Add UMA stats for open and fix memory leak

BUG=
==========

to

==========
Add UMA stats for open and fix memory leak

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tommi (sloooow) - chröme, 2017-02-07 17:24:27]

The CQ bit was checked by tommi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 17:24:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommi (sloooow) - chröme, 2017-02-07 17:30:18]

Fix strange git cl format issue

[tommi (sloooow) - chröme, 2017-02-07 19:32:49]

Description was changed from

==========
Add UMA stats for open and fix memory leak

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add UMA stats to track down issues with opening audio input streams on Windows
and fix memory leak that appears to have been there for a long while.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tommi (sloooow) - chröme, 2017-02-07 19:32:50]

tommi@chromium.org changed reviewers:
+ asvitkine@chromium.org, maxmorin@chromium.org

[tommi (sloooow) - chröme, 2017-02-07 19:33:00]

maxmorin - main review
asvitkine - histograms

[tommi (sloooow) - chröme, 2017-02-07 19:33:07]

The CQ bit was checked by tommi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 19:33:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommi (sloooow) - chröme, 2017-02-07 19:34:46]

https://codereview.chromium.org/2680873002/diff/20001/media/audio/win/audio_l...
File media/audio/win/audio_low_latency_input_win.cc (right):

https://codereview.chromium.org/2680873002/diff/20001/media/audio/win/audio_l...
media/audio/win/audio_low_latency_input_win.cc:307: HANDLE mm_task =
The changes here and below (all of Run()), are the result of git cl format.  Let
me know if you prefer that I revert these changes and keep the code as is.

[tommi (sloooow) - chröme, 2017-02-07 19:36:14]

Description was changed from

==========
Add UMA stats to track down issues with opening audio input streams on Windows
and fix memory leak that appears to have been there for a long while.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add UMA stats to track down issues with opening "high latency" (aka linear)
audio input streams on Windows and fix memory leak that appears to have been
there for a long while.

BUG=684741
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2017-02-07 21:34:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 21:34:21]

Dry run: This issue passed the CQ dry run.

[Max Morin, 2017-02-08 08:08:40]

lgtm

[tommi (sloooow) - chröme, 2017-02-08 09:33:32]

tommi@chromium.org changed reviewers:
+ jochen@chromium.org
- asvitkine@chromium.org

[tommi (sloooow) - chröme, 2017-02-08 09:33:32]

swapping asvitkine for jochen to review histograms.xml as asvitkine is tagged as
"slow"

[jochen (gone - plz use gerrit), 2017-02-08 09:36:30]

... and jochen can only approve UseCounter additions, sorry

[tommi (sloooow) - chröme, 2017-02-08 09:40:56]

tommi@chromium.org changed reviewers:
+ jwd@chromium.org
- jochen@chromium.org

[tommi (sloooow) - chröme, 2017-02-08 09:40:56]

Thanks Jochen, that was quick :)

+jwd for histograms.xml

[tommi (sloooow) - chröme, 2017-02-08 13:12:58]

Description was changed from

==========
Add UMA stats to track down issues with opening "high latency" (aka linear)
audio input streams on Windows and fix memory leak that appears to have been
there for a long while.

BUG=684741
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add UMA stats to track down issues with opening "high latency" (aka linear)
audio input streams on Windows and fix memory leak that appears to have been
there for a long while.

BUG=684741,689976
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tommi (sloooow) - chröme, 2017-02-09 08:29:40]

On 2017/02/08 09:40:56, tommi (krómíum) wrote:
> Thanks Jochen, that was quick :)
> 
> +jwd for histograms.xml

ping jwd for histograms

[jwd, 2017-02-09 16:04:07]

lgtm

https://codereview.chromium.org/2680873002/diff/20001/media/audio/win/audio_l...
File media/audio/win/audio_low_latency_input_win.h (right):

https://codereview.chromium.org/2680873002/diff/20001/media/audio/win/audio_l...
media/audio/win/audio_low_latency_input_win.h:131: // that has no audio
devices).
Mention this enum is used to record a histogram value and shouldn't be
re-ordered.

[tommi (sloooow) - chröme, 2017-02-09 16:31:00]

Add comment

[tommi (sloooow) - chröme, 2017-02-09 16:31:38]

https://codereview.chromium.org/2680873002/diff/20001/media/audio/win/audio_l...
File media/audio/win/audio_low_latency_input_win.h (right):

https://codereview.chromium.org/2680873002/diff/20001/media/audio/win/audio_l...
media/audio/win/audio_low_latency_input_win.h:131: // that has no audio
devices).
On 2017/02/09 16:04:07, jwd wrote:
> Mention this enum is used to record a histogram value and shouldn't be
> re-ordered.

Done.

[tommi (sloooow) - chröme, 2017-02-09 16:32:05]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2017-02-09 16:32:05]

The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org,
maxmorin@chromium.org
Link to the patchset: https://codereview.chromium.org/2680873002/#ps40001
(title: "Add comment")

[commit-bot: I haz the power, 2017-02-09 16:32:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 18:38:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486657925509980,
"parent_rev": "e7f0828e30d63a0c2c5a7113237af8ecb41cfca8", "commit_rev":
"3234f6bb6cfd0343aac4755271f2b8697a8cde49"}

[commit-bot: I haz the power, 2017-02-09 18:38:56]

Description was changed from

==========
Add UMA stats to track down issues with opening "high latency" (aka linear)
audio input streams on Windows and fix memory leak that appears to have been
there for a long while.

BUG=684741,689976
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add UMA stats to track down issues with opening "high latency" (aka linear)
audio input streams on Windows and fix memory leak that appears to have been
there for a long while.

BUG=684741,689976
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2680873002
Cr-Commit-Position: refs/heads/master@{#449359}
Committed:
https://chromium.googlesource.com/chromium/src/+/3234f6bb6cfd0343aac4755271f2...
==========

[commit-bot: I haz the power, 2017-02-09 18:38:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3234f6bb6cfd0343aac4755271f2...

[henrika (OOO until Aug 14), 2017-02-10 07:59:42]

Thanks!