Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2680863007: Refactoring: Remove trivial uses of OutputCapture. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring: Remove trivial uses of OutputCapture. There are a few cases of unit tests that use OutputCapture, where use of OutputCapture doesn't appear to make a difference when tests are run with test-webkitpy: layout_tests/port/base_unittest.py layout_tests/run_webkit_tests_unittest.py tool/commands/optimize_baselines_unittest.py w3c/test_converter_unittest.py BUG=681428 Review-Url: https://codereview.chromium.org/2680863007 Cr-Commit-Position: refs/heads/master@{#449347} Committed: https://chromium.googlesource.com/chromium/src/+/4ef1d5a499fa80a92b5fcfed34d175cfac981d99

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -65 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 1 4 chunks +8 lines, -18 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines_unittest.py View 1 2 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py View 5 chunks +12 lines, -34 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
qyearsley
3 years, 10 months ago (2017-02-09 00:40:49 UTC) #4
jeffcarp
lgtm
3 years, 10 months ago (2017-02-09 00:47:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680863007/1
3 years, 10 months ago (2017-02-09 16:40:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/360632)
3 years, 10 months ago (2017-02-09 16:48:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680863007/20001
3 years, 10 months ago (2017-02-09 17:00:40 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 17:59:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ef1d5a499fa80a92b5fcfed34d1...

Powered by Google App Engine
This is Rietveld 408576698