Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2680863004: [wrapper-tracing] Reset TLS on disposing (Closed)

Created:
3 years, 10 months ago by Michael Lippautz
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Reset TLS on disposing DOMWrapperWorlds can manually be disposed, so we also need to reset the TLS for worker threads in there. BUG=chromium:688120 Review-Url: https://codereview.chromium.org/2673163002 Cr-Commit-Position: refs/heads/master@{#448445} (cherry picked from commit b0a29222e2a01324bce86c9a1880678cedcb4db1) NOTRY=true NOPRESUBMIT=true TBR=haraken@chromium.org Review-Url: https://codereview.chromium.org/2680863004 Cr-Commit-Position: refs/branch-heads/2987@{#384} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/00057db58080022ddff82fc81e7041970bde31c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680863004/1
3 years, 10 months ago (2017-02-08 09:50:56 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-08 09:50:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680863004/1
3 years, 10 months ago (2017-02-08 09:54:34 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 09:57:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00057db58080022ddff82fc81e70...

Powered by Google App Engine
This is Rietveld 408576698