Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2680863003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, abarth-chromium, blink-reviews, darin-cc_chromium.org, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2680863003 Cr-Commit-Position: refs/heads/master@{#459591} Committed: https://chromium.googlesource.com/chromium/src/+/43dd6c1192766bf70c69236bf3cac35aaa3ec79a

Patch Set 1 #

Patch Set 2 : Merge branch 'master' of https://chromium.googlesource.com/chromium/src into mic_adding #

Total comments: 2

Patch Set 3 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/browser/appcache/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/appcache/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/sqlite/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-07 22:47:25 UTC) #1
ymzhang1
3 years, 10 months ago (2017-02-24 19:27:09 UTC) #4
ymzhang1
@michaeln Remainder to review changes in your OWNERS files. +shess@chromium.org to review change in third_party/sqlite/OWNERS. ...
3 years, 9 months ago (2017-03-13 20:52:43 UTC) #5
ymzhang1
+shess@chromium.org to review change in third_party/sqlite/OWNERS
3 years, 9 months ago (2017-03-13 21:47:08 UTC) #7
Scott Hess - ex-Googler
https://codereview.chromium.org/2680863003/diff/20001/third_party/sqlite/OWNERS File third_party/sqlite/OWNERS (right): https://codereview.chromium.org/2680863003/diff/20001/third_party/sqlite/OWNERS#newcode7 third_party/sqlite/OWNERS:7: # COMPONENT: UI This seems like a really odd ...
3 years, 9 months ago (2017-03-13 22:05:19 UTC) #8
ymzhang1
https://codereview.chromium.org/2680863003/diff/20001/third_party/sqlite/OWNERS File third_party/sqlite/OWNERS (right): https://codereview.chromium.org/2680863003/diff/20001/third_party/sqlite/OWNERS#newcode7 third_party/sqlite/OWNERS:7: # COMPONENT: UI On 2017/03/13 22:05:19, Scott Hess wrote: ...
3 years, 9 months ago (2017-03-13 22:15:48 UTC) #9
Scott Hess - ex-Googler
lgtm, we can change it later if someone comes up with a better idea.
3 years, 9 months ago (2017-03-13 22:19:04 UTC) #10
Scott Hess - ex-Googler
On 2017/03/13 22:19:04, Scott Hess wrote: > lgtm, we can change it later if someone ...
3 years, 9 months ago (2017-03-24 18:17:13 UTC) #11
ymzhang1
On 2017/03/24 18:17:13, Scott Hess wrote: > On 2017/03/13 22:19:04, Scott Hess wrote: > > ...
3 years, 9 months ago (2017-03-24 18:33:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680863003/40001
3 years, 9 months ago (2017-03-24 18:34:11 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/394233)
3 years, 9 months ago (2017-03-24 18:50:51 UTC) #16
Scott Hess - ex-Googler
On 2017/03/24 18:33:01, ymzhang1 wrote: > On 2017/03/24 18:17:13, Scott Hess wrote: > > On ...
3 years, 9 months ago (2017-03-24 19:03:24 UTC) #17
michaeln
lgtm 2!
3 years, 9 months ago (2017-03-24 21:54:10 UTC) #18
ymzhang1
On 2017/03/24 21:54:10, michaeln wrote: > lgtm 2! Many thanks!
3 years, 9 months ago (2017-03-24 22:04:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680863003/40001
3 years, 9 months ago (2017-03-24 22:05:22 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 23:06:33 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/43dd6c1192766bf70c69236bf3ca...

Powered by Google App Engine
This is Rietveld 408576698