Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2680803003: [ObjC ARC] Converts ios/chrome/browser/ui/alert_coordinator:eg_tests to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
Reviewers:
gambard, stkhapugin
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/alert_coordinator:eg_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2680803003 Cr-Commit-Position: refs/heads/master@{#449246} Committed: https://chromium.googlesource.com/chromium/src/+/4da2c151d254da2f60b694981362860e005ed562

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M ios/chrome/browser/ui/alert_coordinator/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm View 3 chunks +9 lines, -6 lines 3 comments Download

Messages

Total messages: 14 (8 generated)
lody
Please review, thanks
3 years, 10 months ago (2017-02-08 15:42:30 UTC) #6
gambard
https://codereview.chromium.org/2680803003/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm File ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm (right): https://codereview.chromium.org/2680803003/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm#newcode54 ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm:54: alertCoordinator = nil; The alert coordinator needs to be ...
3 years, 10 months ago (2017-02-08 16:08:29 UTC) #7
stkhapugin
https://codereview.chromium.org/2680803003/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm File ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm (right): https://codereview.chromium.org/2680803003/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm#newcode54 ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm:54: alertCoordinator = nil; On 2017/02/08 16:08:29, gambard wrote: > ...
3 years, 10 months ago (2017-02-08 17:39:29 UTC) #8
gambard
lgtm https://codereview.chromium.org/2680803003/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm File ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm (right): https://codereview.chromium.org/2680803003/diff/1/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm#newcode54 ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm:54: alertCoordinator = nil; On 2017/02/08 17:39:29, stkhapugin wrote: ...
3 years, 10 months ago (2017-02-09 09:06:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680803003/1
3 years, 10 months ago (2017-02-09 09:29:48 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 09:34:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4da2c151d254da2f60b694981362...

Powered by Google App Engine
This is Rietveld 408576698