third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom - Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors (Closed)

Patch Set: Use CreateDOMException instead of take(). Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

diff --git a/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom b/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

index 43ac52f4eb03240f67985e71cd4592ad660db64d..b134e42740aa1e910f6eb714a26dcd82d4707e86 100644

--- a/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

+++ b/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

@@ -51,6 +51,8 @@ enum WebBluetoothResult {

// InvalidStateError:

SERVICE_NO_LONGER_EXISTS,

CHARACTERISTIC_NO_LONGER_EXISTS,

+ INVALID_CHARACTERISTIC,

+ INVALID_DESCRIPTOR,

// NetworkError:

CONNECT_ALREADY_IN_PROGRESS,

CONNECT_ATTRIBUTE_LENGTH_INVALID,

@@ -70,6 +72,8 @@ enum WebBluetoothResult {

DEVICE_NO_LONGER_IN_RANGE,

GATT_NOT_PAIRED,

GATT_OPERATION_IN_PROGRESS,

+ GATT_SERVER_DISCONNECTED,

+ GATT_SERVER_NOT_CONNECTED,

UNTRANSLATED_CONNECT_ERROR_CODE,

// NotFoundError:

NO_BLUETOOTH_ADAPTER,