third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h - Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h

Issue 2680783002: bluetooth: show better error messages for services, characteristics and descriptors (Closed)

Patch Set: Use CreateDOMException instead of take(). Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h

index de176f3baefd53a41ce087a7e7caaed76cedbd26..2d932dafe84b572c7d9bdf888297718ef0b703b2 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h

@@ -6,7 +6,6 @@

#define BluetoothRemoteGATTUtils_h

#include "core/dom/DOMDataView.h"

-#include "core/dom/DOMException.h"

#include "wtf/Vector.h"

namespace blink {

@@ -21,8 +20,6 @@ class BluetoothRemoteGATTUtils final {

kInvalidCharacteristic,

kInvalidDescriptor

dcheng 2017/02/09 19:16:42 Are these still needed?

perja 2017/02/10 13:28:16 Done.

};

- static DOMException* CreateDOMException(ExceptionType);

};

} // namespace blink