Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2680763003: Add MotionMark's <canvas> fill and stroke tests to telemetry. (Closed)

Created:
3 years, 10 months ago by Stephen White
Modified:
3 years, 10 months ago
Reviewers:
nednguyen, achuithb
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add MotionMark's <canvas> fill and stroke tests to telemetry. Add the "Fill shapes" and "Stroke shapes" <canvas> tests, constrained to run with a fixed complexity of 1000. Also assign display names to the pages, so Telemetry doesn't just use a truncated URL. BUG=642376 Review-Url: https://codereview.chromium.org/2680763003 Cr-Commit-Position: refs/heads/master@{#448746} Committed: https://chromium.googlesource.com/chromium/src/+/0ad079ddaea6dedf8656bf374b5c0cd8a601da98

Patch Set 1 #

Patch Set 2 : Simplify: call parent class constructor directly w/named arguments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M tools/perf/page_sets/data/tough_path_rendering_cases.json View 1 chunk +11 lines, -6 lines 0 comments Download
A tools/perf/page_sets/data/tough_path_rendering_cases_002.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/tough_path_rendering_cases.py View 1 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Stephen White
achuith@: PTAL. Thanks!
3 years, 10 months ago (2017-02-07 20:01:29 UTC) #5
achuithb
Ned should be able to find a better reviewer for this.
3 years, 10 months ago (2017-02-07 20:07:53 UTC) #7
nednguyen
lgtm
3 years, 10 months ago (2017-02-07 20:10:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680763003/20001
3 years, 10 months ago (2017-02-07 20:12:20 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 22:30:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0ad079ddaea6dedf8656bf374b5c...

Powered by Google App Engine
This is Rietveld 408576698