Android: Fix values to use standard type

Android: Fix values to use standard type

"float" is not a values type, and since we only use this in java code
through R.*, we can safely switch to dimen as an actual type. Creates an
error in Android Studio otherwise.

BUG=620034
Review-Url: https://codereview.chromium.org/2680723004
Cr-Commit-Position: refs/heads/master@{#449055}
Committed: https://chromium.googlesource.com/chromium/src/+/4753da96bbda64aabd9870cf37290ece01160f66

[Peter Wen, 2017-02-07 22:45:53]

wnwen@chromium.org changed reviewers:
+ agrieve@chromium.org

[Peter Wen, 2017-02-07 22:45:54]

Hi Andrew,

Does this make sense? There's a couple fixes to our resources xml and png
(removing dups mostly) before Android Studio and gradle likes them.

Thanks,

Peter

[agrieve, 2017-02-08 01:36:23]

afaict, lgtm.

Might be worth creating a whitelist of valid resource types in:
https://cs.chromium.org/chromium/src/build/android/gyp/process_resources.py

So that this will be a build error.

[Peter Wen, 2017-02-08 13:40:23]

wnwen@chromium.org changed reviewers:
+ nyquist@chromium.org, twellington@chromium.org

[Peter Wen, 2017-02-08 13:40:23]

+twellington@ for chrome/android/java/res OWNERS
+nyquist@ for chrome/android OWNERS

Thanks for the review, Andrew. I'll add a check to process_resources.py after
this CL lands.

[Theresa, 2017-02-08 15:26:14]

lgtm

[nyquist, 2017-02-08 16:52:52]

lgtm

[Peter Wen, 2017-02-08 18:29:37]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2017-02-08 18:30:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 19:09:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486578577707350, "parent_rev":
"d477de2472e081ee836f6422535c04b6cf82e330", "commit_rev":
"4753da96bbda64aabd9870cf37290ece01160f66"}

[commit-bot: I haz the power, 2017-02-08 19:09:43]

Description was changed from

==========
Android: Fix values to use standard type

"float" is not a values type, and since we only use this in java code
through R.*, we can safely switch to dimen as an actual type. Creates an
error in Android Studio otherwise.

BUG=620034
==========

to

==========
Android: Fix values to use standard type

"float" is not a values type, and since we only use this in java code
through R.*, we can safely switch to dimen as an actual type. Creates an
error in Android Studio otherwise.

BUG=620034

Review-Url: https://codereview.chromium.org/2680723004
Cr-Commit-Position: refs/heads/master@{#449055}
Committed:
https://chromium.googlesource.com/chromium/src/+/4753da96bbda64aabd9870cf3729...
==========

[commit-bot: I haz the power, 2017-02-08 19:09:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4753da96bbda64aabd9870cf3729...