Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2680683003: Remove faulty assertion in LayoutSVGResourceContainer::registerResource (Closed)

Created:
3 years, 10 months ago by fs
Modified:
3 years, 10 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove faulty assertion in LayoutSVGResourceContainer::registerResource When notifying pending elements we don't know what resource type the registration is for, so it's entirely plausible that the resource type is one that a possible client isn't really interested in (like a 'mask' ending up pointing to a <filter>, like in this particular case.) BUG=687985 Review-Url: https://codereview.chromium.org/2680683003 Cr-Commit-Position: refs/heads/master@{#448688} Committed: https://chromium.googlesource.com/chromium/src/+/eeca548902f5508923a683529845f369cc392c6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/svg/masking/mask-valid-reference-wrong-element-type-crash.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/masking/mask-valid-reference-wrong-element-type-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 10 months ago (2017-02-07 18:18:04 UTC) #6
pdr.
On 2017/02/07 at 18:18:04, fs wrote: > LGTM
3 years, 10 months ago (2017-02-07 19:07:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680683003/1
3 years, 10 months ago (2017-02-07 19:11:02 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 19:16:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eeca548902f5508923a683529845...

Powered by Google App Engine
This is Rietveld 408576698