Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2680653002: [gin] Removing file validation. (Closed)

Created:
3 years, 10 months ago by Jay Civelli
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[gin] Removing file validation. Removes extra v8 snapshot and natives validation on Windows. This was added a while ago to track down a bug with corrupted v8 files. This is a relanding of: https://codereview.chromium.org/2103903002/ BUG=501799 Review-Url: https://codereview.chromium.org/2680653002 Cr-Commit-Position: refs/heads/master@{#448646} Committed: https://chromium.googlesource.com/chromium/src/+/dbe3dec51ed397be17f98e9c552ebd984aa2b379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -189 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M gin/BUILD.gn View 2 chunks +0 lines, -35 lines 0 comments Download
D gin/fingerprint/fingerprint_v8_snapshot.py View 1 chunk +0 lines, -86 lines 0 comments Download
M gin/v8_initializer.cc View 5 chunks +12 lines, -64 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Jay Civelli
3 years, 10 months ago (2017-02-07 01:40:05 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-07 15:10:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680653002/1
3 years, 10 months ago (2017-02-07 16:53:43 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 16:59:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbe3dec51ed397be17f98e9c552e...

Powered by Google App Engine
This is Rietveld 408576698