Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2680643002: Add old_state parameter to CustomButton::StateChanged (Closed)

Created:
3 years, 10 months ago by Tom (Use chromium acct)
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, Peter Beverloo, tfarina, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add old_state parameter to CustomButton::StateChanged This change is necessary for https://codereview.chromium.org/2624683002/ BUG=677286 R=sky@chromium.org Review-Url: https://codereview.chromium.org/2680643002 Cr-Commit-Position: refs/heads/master@{#448486} Committed: https://chromium.googlesource.com/chromium/src/+/8af777bf6b7bdd749632cfa5c2fde7a3f98038c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M ash/common/system/chromeos/audio/volume_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/network/network_state_list_detailed_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/tray_popup_header_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/tray_popup_header_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_request_row_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_request_row_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_item_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/tile_item_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/tile_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/chromeos/ime/candidate_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/chromeos/ime/candidate_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/custom_button.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/label_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/md_text_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/md_text_button.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/menu_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/menu_button.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 2624683002 Patch 180001
Issue 2624683002 Patch 200001

Messages

Total messages: 13 (9 generated)
Tom (Use chromium acct)
sky ptal
3 years, 10 months ago (2017-02-06 23:52:02 UTC) #4
sky
LGTM
3 years, 10 months ago (2017-02-07 00:25:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680643002/20001
3 years, 10 months ago (2017-02-07 01:05:12 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 01:14:30 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8af777bf6b7bdd749632cfa5c2fd...

Powered by Google App Engine
This is Rietveld 408576698