Issue 268063005: Clean up hash creation code to use Handle<Smi> where possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268063005: Clean up hash creation code to use Handle<Smi> where possible (Closed)

Created:
6 years, 7 months ago by adamk

Modified:
6 years, 7 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev, arv (Not doing code reviews)

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Clean up hash creation code to use Handle<Smi> where possible Also remove apparently-bogus TODO and reorder arguments in Object::GetOrCreateHash to put Isolate first (as seems to be the custom). R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21246

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -29 lines)			Patch
M	src/api.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/objects.h	View	4 chunks	+4 lines, -7 lines	0 comments	Download
M	src/objects.cc	View	8 chunks	+17 lines, -19 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

adamk

6 years, 7 months ago (2014-05-09 18:31:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21246 (presubmit successful).