Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: src/objects-inl.h

Issue 268063005: Clean up hash creation code to use Handle<Smi> where possible (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 6302 matching lines...) Expand 10 before | Expand all | Expand 10 after
6313 bool JSGlobalObject::IsDetached() { 6313 bool JSGlobalObject::IsDetached() {
6314 return JSGlobalProxy::cast(global_receiver())->IsDetachedFrom(this); 6314 return JSGlobalProxy::cast(global_receiver())->IsDetachedFrom(this);
6315 } 6315 }
6316 6316
6317 6317
6318 bool JSGlobalProxy::IsDetachedFrom(GlobalObject* global) { 6318 bool JSGlobalProxy::IsDetachedFrom(GlobalObject* global) {
6319 return GetPrototype() != global; 6319 return GetPrototype() != global;
6320 } 6320 }
6321 6321
6322 6322
6323 Handle<Object> JSReceiver::GetOrCreateIdentityHash(Handle<JSReceiver> object) { 6323 Handle<Smi> JSReceiver::GetOrCreateIdentityHash(Handle<JSReceiver> object) {
6324 return object->IsJSProxy() 6324 return object->IsJSProxy()
6325 ? JSProxy::GetOrCreateIdentityHash(Handle<JSProxy>::cast(object)) 6325 ? JSProxy::GetOrCreateIdentityHash(Handle<JSProxy>::cast(object))
6326 : JSObject::GetOrCreateIdentityHash(Handle<JSObject>::cast(object)); 6326 : JSObject::GetOrCreateIdentityHash(Handle<JSObject>::cast(object));
6327 } 6327 }
6328 6328
6329 6329
6330 Object* JSReceiver::GetIdentityHash() { 6330 Object* JSReceiver::GetIdentityHash() {
6331 return IsJSProxy() 6331 return IsJSProxy()
6332 ? JSProxy::cast(this)->GetIdentityHash() 6332 ? JSProxy::cast(this)->GetIdentityHash()
6333 : JSObject::cast(this)->GetIdentityHash(); 6333 : JSObject::cast(this)->GetIdentityHash();
(...skipping 522 matching lines...) Expand 10 before | Expand all | Expand 10 after
6856 #undef READ_SHORT_FIELD 6856 #undef READ_SHORT_FIELD
6857 #undef WRITE_SHORT_FIELD 6857 #undef WRITE_SHORT_FIELD
6858 #undef READ_BYTE_FIELD 6858 #undef READ_BYTE_FIELD
6859 #undef WRITE_BYTE_FIELD 6859 #undef WRITE_BYTE_FIELD
6860 #undef NOBARRIER_READ_BYTE_FIELD 6860 #undef NOBARRIER_READ_BYTE_FIELD
6861 #undef NOBARRIER_WRITE_BYTE_FIELD 6861 #undef NOBARRIER_WRITE_BYTE_FIELD
6862 6862
6863 } } // namespace v8::internal 6863 } } // namespace v8::internal
6864 6864
6865 #endif // V8_OBJECTS_INL_H_ 6865 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698