Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2680613002: [Extensions UI Mac] Update external install prompt strings to titlecase (Closed)

Created:
3 years, 10 months ago by Devlin
Modified:
3 years, 10 months ago
Reviewers:
shrike
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI Mac] Update external install prompt strings to titlecase Mac uses title case for buttons. Update the external install prompt strings to use title case. BUG=669277 BUG=689227 Review-Url: https://codereview.chromium.org/2680613002 Cr-Commit-Position: refs/heads/master@{#448448} Committed: https://chromium.googlesource.com/chromium/src/+/708150fa6719a691befd72702ac6d5221db6d853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +22 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Devlin
Mind taking a look? This updates the strings for the external install bubble and dialog, ...
3 years, 10 months ago (2017-02-06 22:27:39 UTC) #5
shrike
lgtm
3 years, 10 months ago (2017-02-06 22:41:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680613002/1
3 years, 10 months ago (2017-02-06 23:51:38 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 23:58:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/708150fa6719a691befd72702ac6...

Powered by Google App Engine
This is Rietveld 408576698