FileReader.abort() should not fire an error event.

FileReader.abort() should not fire an error event.

The 'error', 'abort' and 'load' events are mutually exclusive. Each read
operation should only result in one of these events. So stop the error
event from being fired by the abort method, to align our behavior with
at least firefox and edge.

(at the time our implementation was written, the spec did still require
an error event as well for this case, but that was changed fairly soon after
in the spec)

Test landed upstream in https://github.com/w3c/web-platform-tests/pull/4747

BUG=689208
Review-Url: https://codereview.chromium.org/2680603002
Cr-Commit-Position: refs/heads/master@{#448714}
Committed: https://chromium.googlesource.com/chromium/src/+/c78653065fa6d8fb524e48a5d7232f3ab5eab4ab

[Marijn Kruisselbrink, 2017-02-06 22:02:54]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 22:03:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-06 22:04:22]

Description was changed from

==========
FileReader.abort() should not fire an error event.

The 'error', 'abort' and 'load' events are mutually exclusive. Each read
operation should only result in one of these events. So stop the error
event from being fired by the abort method, to align our behavior with
at least firefox and edge.

BUG=689208
==========

to

==========
FileReader.abort() should not fire an error event.

The 'error', 'abort' and 'load' events are mutually exclusive. Each read
operation should only result in one of these events. So stop the error
event from being fired by the abort method, to align our behavior with
at least firefox and edge.

Test landed upstream in https://github.com/w3c/web-platform-tests/pull/4747

BUG=689208
==========

[Marijn Kruisselbrink, 2017-02-06 22:20:45]

Description was changed from

==========
FileReader.abort() should not fire an error event.

The 'error', 'abort' and 'load' events are mutually exclusive. Each read
operation should only result in one of these events. So stop the error
event from being fired by the abort method, to align our behavior with
at least firefox and edge.

Test landed upstream in https://github.com/w3c/web-platform-tests/pull/4747

BUG=689208
==========

to

==========
FileReader.abort() should not fire an error event.

The 'error', 'abort' and 'load' events are mutually exclusive. Each read
operation should only result in one of these events. So stop the error
event from being fired by the abort method, to align our behavior with
at least firefox and edge.

(at the time our implementation was written, the spec did still require
an error event as well for this case, but that was changed fairly soon after
in the spec)

Test landed upstream in https://github.com/w3c/web-platform-tests/pull/4747

BUG=689208
==========

[commit-bot: I haz the power, 2017-02-06 23:35:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 23:35:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marijn Kruisselbrink, 2017-02-06 23:58:10]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 23:58:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-07 01:11:05]

mek@chromium.org changed reviewers:
+ kinuko@chromium.org

[commit-bot: I haz the power, 2017-02-07 01:35:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 01:35:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kinuko, 2017-02-07 04:45:49]

Looks like it broke tests?

(The code change itself lgtm)

[Marijn Kruisselbrink, 2017-02-07 18:27:30]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 18:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-07 18:39:27]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 18:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-07 19:36:06]

On 2017/02/07 at 04:45:49, kinuko wrote:
> Looks like it broke tests?

Ah yes, seems that one test indeed relied on abort() firing an error event.
Fixed the test. I still believe this change should be safe enough to make, since
other browsers already behave this way, and looking through some of the usage of
FileReader in extensions I couldn't find anything problematic either.

[Marijn Kruisselbrink, 2017-02-07 19:39:37]

The CQ bit was unchecked by mek@chromium.org

[Marijn Kruisselbrink, 2017-02-07 19:39:40]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2017-02-07 19:39:40]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2680603002/#ps60001
(title: "Remove fixed wpt test expectation.")

[commit-bot: I haz the power, 2017-02-07 19:39:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 20:13:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486496380570590,
"parent_rev": "16305b01e5fa25c11eff50d34238bc6576781fa4", "commit_rev":
"c78653065fa6d8fb524e48a5d7232f3ab5eab4ab"}

[commit-bot: I haz the power, 2017-02-07 20:14:43]

Description was changed from

==========
FileReader.abort() should not fire an error event.

The 'error', 'abort' and 'load' events are mutually exclusive. Each read
operation should only result in one of these events. So stop the error
event from being fired by the abort method, to align our behavior with
at least firefox and edge.

(at the time our implementation was written, the spec did still require
an error event as well for this case, but that was changed fairly soon after
in the spec)

Test landed upstream in https://github.com/w3c/web-platform-tests/pull/4747

BUG=689208
==========

to

==========
FileReader.abort() should not fire an error event.

The 'error', 'abort' and 'load' events are mutually exclusive. Each read
operation should only result in one of these events. So stop the error
event from being fired by the abort method, to align our behavior with
at least firefox and edge.

(at the time our implementation was written, the spec did still require
an error event as well for this case, but that was changed fairly soon after
in the spec)

Test landed upstream in https://github.com/w3c/web-platform-tests/pull/4747

BUG=689208

Review-Url: https://codereview.chromium.org/2680603002
Cr-Commit-Position: refs/heads/master@{#448714}
Committed:
https://chromium.googlesource.com/chromium/src/+/c78653065fa6d8fb524e48a5d723...
==========

[commit-bot: I haz the power, 2017-02-07 20:14:44]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c78653065fa6d8fb524e48a5d723...