Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2680543003: DevTools: Show scrollbars on a small FilteredListWidget (Closed)

Created:
3 years, 10 months ago by einbinder
Modified:
3 years, 10 months ago
Reviewers:
lushnikov, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Show scrollbars on a small FilteredListWidget BUG=688933 Review-Url: https://codereview.chromium.org/2680543003 Cr-Commit-Position: refs/heads/master@{#448446} Committed: https://chromium.googlesource.com/chromium/src/+/35ab0f010dd7ca82e59c9d31114e033780e4b9e6

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js View 1 chunk +2 lines, -1 line 1 comment Download
M third_party/WebKit/Source/devtools/front_end/quick_open/filteredListWidget.css View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Dialog.js View 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js View 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
einbinder
ptal
3 years, 10 months ago (2017-02-06 20:05:02 UTC) #2
pfeldman
https://codereview.chromium.org/2680543003/diff/1/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js File third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js (right): https://codereview.chromium.org/2680543003/diff/1/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js#newcode122 third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js:122: this._dialog.setFixedHeight(false); Looking at the bug, I don't see where ...
3 years, 10 months ago (2017-02-06 21:41:45 UTC) #4
einbinder
On 2017/02/06 at 21:41:45, pfeldman wrote: > https://codereview.chromium.org/2680543003/diff/1/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js > File third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js (right): > > https://codereview.chromium.org/2680543003/diff/1/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js#newcode122 ...
3 years, 10 months ago (2017-02-06 21:46:31 UTC) #5
pfeldman
lgtm
3 years, 10 months ago (2017-02-06 21:53:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680543003/1
3 years, 10 months ago (2017-02-06 21:55:10 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 23:55:41 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/35ab0f010dd7ca82e59c9d31114e...

Powered by Google App Engine
This is Rietveld 408576698