Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2680493002: Use STLClearObject in URLFetcherCore (Closed)

Created:
3 years, 10 months ago by xunjieli
Modified:
3 years, 10 months ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use STLClearObject in URLFetcherCore URLFetcherCore can be reused for different requests. If it is used for a chunked upload following a non-chunked upload, we clear the previous non-chunked upload content by doing |upload_content_|.clear(). However this might not free up the memory used by |upload_content_|. This CL uses base::STLClearObject(). BUG=689062 Review-Url: https://codereview.chromium.org/2680493002 Cr-Commit-Position: refs/heads/master@{#448297} Committed: https://chromium.googlesource.com/chromium/src/+/247c7485836209481c53e865856ec7b8ef81178e

Patch Set 1 : self #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/url_request/url_fetcher_core.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
xunjieli
Bence, PTAL. Thanks!
3 years, 10 months ago (2017-02-06 16:19:50 UTC) #3
Bence
LGTM.
3 years, 10 months ago (2017-02-06 16:25:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680493002/20001
3 years, 10 months ago (2017-02-06 16:38:11 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 17:53:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/247c7485836209481c53e865856e...

Powered by Google App Engine
This is Rietveld 408576698