Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2680473002: [ObjC ARC] Converts ios/chrome/browser/ui/toolbar:eg_tests to ARC. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/toolbar:eg_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2680473002 Cr-Commit-Position: refs/heads/master@{#448300} Committed: https://chromium.googlesource.com/chromium/src/+/f48c0d29252161f18443369409d694adee2919cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M ios/chrome/browser/ui/toolbar/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_egtest.mm View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
stkhapugin
PTAL 🐈
3 years, 10 months ago (2017-02-06 17:45:31 UTC) #6
sdefresne
lgtm
3 years, 10 months ago (2017-02-06 17:50:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680473002/1
3 years, 10 months ago (2017-02-06 17:56:04 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 18:03:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f48c0d29252161f18443369409d6...

Powered by Google App Engine
This is Rietveld 408576698