Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 2680463002: Convert ContentPasswordManagerDriver to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc
index c9d75761b69c5804e9b530da34aa7423d3db5463..bdb9361bb0d4e59cc27bff2ced8df2865d9756d8 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.cc
+++ b/components/password_manager/content/browser/content_password_manager_driver.cc
@@ -15,8 +15,8 @@
#include "components/password_manager/core/browser/password_manager_client.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/child_process_security_policy.h"
-#include "content/public/browser/navigation_details.h"
#include "content/public/browser/navigation_entry.h"
+#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
@@ -214,10 +214,9 @@ void ContentPasswordManagerDriver::
}
void ContentPasswordManagerDriver::DidNavigateFrame(
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) {
+ content::NavigationHandle* navigation_handle) {
// Clear page specific data after main frame navigation.
- if (!render_frame_host_->GetParent() && !details.is_in_page) {
+ if (navigation_handle->IsInMainFrame() && !navigation_handle->IsSamePage()) {
GetPasswordManager()->DidNavigateMainFrame();
GetPasswordAutofillManager()->DidNavigateMainFrame();
}

Powered by Google App Engine
This is Rietveld 408576698