Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2680453004: PlzNavigate: avoid checking navigation policy twice for render-init requests. (Closed)

Created:
3 years, 10 months ago by yzshen1
Modified:
3 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, blink-reviews, einbinder+watch-test-runner_chromium.org, mlamouri+watch-test-runner_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: avoid checking navigation policy twice for render-init requests. Some layout tests expect that navigation policy is checked only once, although we should probably change the expectation and avoid this hack once PlzNavigate fully takes over. BUG=673765 Review-Url: https://codereview.chromium.org/2680453004 Cr-Commit-Position: refs/heads/master@{#448559} Committed: https://chromium.googlesource.com/chromium/src/+/a6bd9edba94b179253c09f99ced143a0cf195e74

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M components/test_runner/web_frame_test_client.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
3 years, 10 months ago (2017-02-06 19:24:01 UTC) #4
jam
lgtm
3 years, 10 months ago (2017-02-07 01:20:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680453004/1
3 years, 10 months ago (2017-02-07 05:58:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a6bd9edba94b179253c09f99ced143a0cf195e74
3 years, 10 months ago (2017-02-07 06:03:54 UTC) #12
findit-for-me
3 years, 10 months ago (2017-02-07 06:16:17 UTC) #13
Message was sent while issue was closed.
FYI: Findit identified this CL at revision 448559 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Powered by Google App Engine
This is Rietveld 408576698