Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2680443002: [parsing] Make maybe-assigned more precise for sloppy block functions. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 10 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parsing] Make maybe-assigned more precise for sloppy block functions. A script like "{ function foo() {} }" declares a VAR-variable at the top-level and a LET-variable inside the block. The LET-variable does not need to be unconditionally marked as assigned. BUG=v8:5636 Review-Url: https://codereview.chromium.org/2680443002 Cr-Commit-Position: refs/heads/master@{#42980} Committed: https://chromium.googlesource.com/v8/v8/+/b87d99495e972ee76254cbe912626707da0785c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/parsing/parser.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
neis
PTAL. A test about this is in the follow-up CL.
3 years, 10 months ago (2017-02-06 15:54:31 UTC) #6
adamk
lgtm
3 years, 10 months ago (2017-02-06 20:06:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680443002/1
3 years, 10 months ago (2017-02-07 07:34:53 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 08:13:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b87d99495e972ee76254cbe912626707da0...

Powered by Google App Engine
This is Rietveld 408576698