[ObjC ARC] Converts ios/chrome/browser/ui/first_run:first_run to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/first_run:first_run to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Annotated FirstRunChromeSigninViewController's _tabModel and _identity as __weak.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2680433002
Cr-Commit-Position: refs/heads/master@{#448935}
Committed: https://chromium.googlesource.com/chromium/src/+/527535830fcb2e3410f09962ca496067f7d438a3

[lody, 2017-02-06 15:00:05]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 15:00:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lody, 2017-02-06 15:07:25]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/first_run:first_run to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/first_run:first_run to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Annotated FirstRunChromeSigninViewController's _tabModel and _identity as
__weak.

BUG=624363
TEST=None
==========

[lody, 2017-02-06 15:07:36]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 15:07:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lody, 2017-02-06 16:01:22]

lod@chromium.org changed reviewers:
+ bzanotti@chromium.org, stkhapugin@chromium.org

[lody, 2017-02-06 16:01:23]

Please review, thank you 🍔

[commit-bot: I haz the power, 2017-02-06 16:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 16:03:12]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-02-06 18:07:20]

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
File ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm (right):

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm:90: @property(weak,
nonatomic, readonly) UIView* containerView;
Here and below, since those were backed with scoped_nsobject, make these strong

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm:189: _delegate =
delegate;
Remove this, as this can now be synthesized. Same for getter above.

[bzanotti, 2017-02-06 18:35:31]

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
File ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm (right):

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm:76: __weak
id<WelcomeToChromeViewDelegate> _delegate;
You should be able to remove this entirely and use the auto-synthesized
property.

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
File ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm
(right):

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm:51:
ios::ChromeBrowserState* browserState_;  // weak
Shouldn't it have __weak added as well?

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm:52:
TabModel* tabModel_;                     // weak
Same here.

[lody, 2017-02-07 14:10:12]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 14:10:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 15:03:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 15:03:38]

Dry run: This issue passed the CQ dry run.

[lody, 2017-02-07 15:46:50]

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
File ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm (right):

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm:76: __weak
id<WelcomeToChromeViewDelegate> _delegate;
On 2017/02/06 18:35:31, bzanotti wrote:
> You should be able to remove this entirely and use the auto-synthesized
> property.

Done.

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm:90: @property(weak,
nonatomic, readonly) UIView* containerView;
On 2017/02/06 18:07:20, stkhapugin wrote:
> Here and below, since those were backed with scoped_nsobject, make these
strong

Done.

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm:189: _delegate =
delegate;
On 2017/02/06 18:07:20, stkhapugin wrote:
> Remove this, as this can now be synthesized. Same for getter above. 

Done.

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
File ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm
(right):

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm:51:
ios::ChromeBrowserState* browserState_;  // weak
On 2017/02/06 18:35:31, bzanotti wrote:
> Shouldn't it have __weak added as well?

no, because it is C++

https://codereview.chromium.org/2680433002/diff/20001/ios/chrome/browser/ui/f...
ios/chrome/browser/ui/first_run/welcome_to_chrome_view_controller.mm:52:
TabModel* tabModel_;                     // weak
On 2017/02/06 18:35:31, bzanotti wrote:
> Same here.

yep.

[bzanotti, 2017-02-07 22:57:07]

lgtm

[lody, 2017-02-08 09:00:32]

The CQ bit was checked by lod@chromium.org

[commit-bot: I haz the power, 2017-02-08 09:01:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 09:05:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486544432504800,
"parent_rev": "8e9e0ae46f07e113016903cd139c695e78e152fe", "commit_rev":
"527535830fcb2e3410f09962ca496067f7d438a3"}

[commit-bot: I haz the power, 2017-02-08 09:06:40]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/first_run:first_run to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Annotated FirstRunChromeSigninViewController's _tabModel and _identity as
__weak.

BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/first_run:first_run to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* Annotated FirstRunChromeSigninViewController's _tabModel and _identity as
__weak.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2680433002
Cr-Commit-Position: refs/heads/master@{#448935}
Committed:
https://chromium.googlesource.com/chromium/src/+/527535830fcb2e3410f09962ca49...
==========

[commit-bot: I haz the power, 2017-02-08 09:06:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/527535830fcb2e3410f09962ca49...