Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2680423005: Reland "Android: Add owned resources to android studio" (Closed)

Created:
3 years, 10 months ago by Peter Wen
Modified:
3 years, 10 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Android: Add owned resources to android studio" Original Reland: https://codereview.chromium.org/2687453002/ Changes: - Fix TypeError: 'NoneType' object is not iterable TBR=agrieve@chromium.org BUG=682846 Review-Url: https://codereview.chromium.org/2680423005 Cr-Commit-Position: refs/heads/master@{#449408} Committed: https://chromium.googlesource.com/chromium/src/+/0227e4a51b9dd67d5735d53aff95b8fa70a9e291

Patch Set 1 #

Patch Set 2 : Fix type error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -15 lines) Patch
M build/android/gradle/android.jinja View 1 chunk +5 lines, -0 lines 0 comments Download
M build/android/gradle/generate_gradle.py View 1 10 chunks +31 lines, -10 lines 0 comments Download
M docs/android_studio.md View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680423005/20001
3 years, 10 months ago (2017-02-09 19:49:09 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 21:15:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0227e4a51b9dd67d5735d53aff95...

Powered by Google App Engine
This is Rietveld 408576698